Skip to content

Commit 63b4dff

Browse files
Google APIscopybara-github
Google APIs
authored and
copybara-github
committed
chore: remove empty extra_opts from the C# proto library
feat: deprecate INVALID_COUNTRY_CODE and add MEMBERSHIP_DURATION_TOO_LONG to the ErrorReason enum docs: update filter field documentation to clarify case requirements and improve examples fix!: update publisher_name in PairIdInfo to be required fix!: update match_rate_percentage in PairIdInfo to be required fix!: feat: update advertiser_identifier_count in PairIdInfo to be optional PiperOrigin-RevId: 878469306
1 parent cecc73b commit 63b4dff

File tree

7 files changed

+47
-26
lines changed

7 files changed

+47
-26
lines changed

‎google/ads/datamanager/v1/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,6 @@ load(
368368

369369
csharp_proto_library(
370370
name = "datamanager_csharp_proto",
371-
extra_opts = [],
372371
deps = [":datamanager_proto"],
373372
)
374373

‎google/ads/datamanager/v1/error.proto‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ enum ErrorReason {
6666
// Postal code is not valid.
6767
INVALID_POSTAL_CODE = 12;
6868

69-
// Country code is not valid.
70-
INVALID_COUNTRY_CODE = 13;
69+
// Deprecated: Enum is unused in the Data Manager API.
70+
INVALID_COUNTRY_CODE = 13 [deprecated = true];
7171

7272
// Enum value cannot be used.
7373
INVALID_ENUM_VALUE = 14;
@@ -336,4 +336,7 @@ enum ErrorReason {
336336

337337
// The account types are not supported for the partner link.
338338
UNSUPPORTED_ACCOUNT_TYPE_FOR_PARTNER_LINK = 98;
339+
340+
// The user list membership duration is too long.
341+
MEMBERSHIP_DURATION_TOO_LONG = 99;
339342
}

‎google/ads/datamanager/v1/partner_link_service.proto‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,12 @@ message SearchPartnerLinksRequest {
164164
// must match the call that provided the page token.
165165
string page_token = 3;
166166

167-
// Optional. A [filter string](//google.aip.dev/160). All fields need to be on
168-
// the left hand side of each condition (for example: `partner_link_id =
169-
// 123456789`).
167+
// Optional. A [filter string](https://google.aip.dev/160). All fields need to
168+
// be on the left hand side of each condition (for example: `partner_link_id =
169+
// 123456789`). Fields must be specified using either all [camel
170+
// case](https://en.wikipedia.org/wiki/Camel_case) or all [snake
171+
// case](https://en.wikipedia.org/wiki/Snake_case). Don't use a combination of
172+
// camel case and snake case.
170173
//
171174
// Supported operations:
172175
//
@@ -183,8 +186,8 @@ message SearchPartnerLinksRequest {
183186
// - `partner_account.account_id`
184187
//
185188
// Example:
186-
// `owning_account.account_type = "GOOGLE_ADS" OR partner_account.account_id =
187-
// 987654321`
189+
// `owning_account.account_type = "GOOGLE_ADS" AND partner_account.account_id
190+
// = 987654321`
188191
string filter = 4 [(google.api.field_behavior) = OPTIONAL];
189192
}
190193

‎google/ads/datamanager/v1/user_list.proto‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -317,20 +317,21 @@ message PairIdInfo {
317317
(google.api.field_behavior) = IMMUTABLE
318318
];
319319

320-
// Optional. Descriptive name of the publisher to be displayed in the UI for a
320+
// Required. Descriptive name of the publisher to be displayed in the UI for a
321321
// better targeting experience.
322-
optional string publisher_name = 2 [(google.api.field_behavior) = OPTIONAL];
322+
optional string publisher_name = 2 [(google.api.field_behavior) = REQUIRED];
323323

324-
// Output only. This field denotes the percentage of membership match of this
324+
// Required. This field denotes the percentage of membership match of this
325325
// user list with the corresponding publisher's first party data. Must be
326326
// between 0 and 100 inclusive.
327-
int32 match_rate_percentage = 3 [(google.api.field_behavior) = OUTPUT_ONLY];
327+
optional int32 match_rate_percentage = 3
328+
[(google.api.field_behavior) = REQUIRED];
328329

329-
// Output only. The count of the advertiser's first party data records that
330-
// have been uploaded to a clean room provider. This does not signify the size
331-
// of a PAIR user list.
332-
int64 advertiser_identifier_count = 4
333-
[(google.api.field_behavior) = OUTPUT_ONLY];
330+
// Optional. The count of the advertiser's first party data records that have
331+
// been uploaded to a clean room provider. This does not signify the size of a
332+
// PAIR user list.
333+
optional int64 advertiser_identifier_count = 4
334+
[(google.api.field_behavior) = OPTIONAL];
334335

335336
// Required. Immutable. Identifies a unique advertiser to publisher
336337
// relationship with one clean room provider or across multiple clean room

‎google/ads/datamanager/v1/user_list_direct_license_service.proto‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,12 @@ message ListUserListDirectLicensesRequest {
148148
}
149149
];
150150

151-
// Optional. Filters to apply to the list request. All fields need to be on
152-
// the left hand side of each condition (for example: user_list_id = 123).
151+
// Optional. A [filter string](https://google.aip.dev/160) to apply to the
152+
// list request. All fields need to be on the left hand side of each condition
153+
// (for example: `user_list_id = 123`). Fields must be specified using either
154+
// all [camel case](https://en.wikipedia.org/wiki/Camel_case) or all [snake
155+
// case](https://en.wikipedia.org/wiki/Snake_case). Don't use a combination of
156+
// camel case and snake case.
153157
//
154158
// **Supported Operations:**
155159
//

‎google/ads/datamanager/v1/user_list_global_license_service.proto‎

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,12 @@ message ListUserListGlobalLicensesRequest {
160160
}
161161
];
162162

163-
// Optional. Filters to apply to the list request. All fields need to be on
164-
// the left hand side of each condition (for example: user_list_id = 123).
163+
// Optional. A [filter string](https://google.aip.dev/160) to apply to the
164+
// list request. All fields need to be on the left hand side of each condition
165+
// (for example: `user_list_id = 123`). Fields must be specified using either
166+
// all [camel case](https://en.wikipedia.org/wiki/Camel_case) or all [snake
167+
// case](https://en.wikipedia.org/wiki/Snake_case). Don't use a combination of
168+
// camel case and snake case.
165169
//
166170
// **Supported Operations:**
167171
//
@@ -225,8 +229,12 @@ message ListUserListGlobalLicenseCustomerInfosRequest {
225229
}
226230
];
227231

228-
// Optional. Filters to apply to the list request. All fields need to be on
229-
// the left hand side of each condition (for example: user_list_id = 123).
232+
// Optional. A [filter string](https://google.aip.dev/160) to apply to the
233+
// list request. All fields need to be on the left hand side of each condition
234+
// (for example: `user_list_id = 123`). Fields must be specified using either
235+
// all [camel case](https://en.wikipedia.org/wiki/Camel_case) or all [snake
236+
// case](https://en.wikipedia.org/wiki/Snake_case). Don't use a combination of
237+
// camel case and snake case.
230238
//
231239
// **Supported Operations:**
232240
//

‎google/ads/datamanager/v1/user_list_service.proto‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,9 +183,12 @@ message ListUserListsRequest {
183183
// match the call that provided the page token.
184184
string page_token = 3 [(google.api.field_behavior) = OPTIONAL];
185185

186-
// Optional. A [filter string](//google.aip.dev/160). All fields need to be on
187-
// the left hand side of each condition (for example: `display_name = "list
188-
// 1"`).
186+
// Optional. A [filter string](https://google.aip.dev/160). All fields need to
187+
// be on the left hand side of each condition (for example: `display_name =
188+
// "list 1"`). Fields must be specified using either all [camel
189+
// case](https://en.wikipedia.org/wiki/Camel_case) or all [snake
190+
// case](https://en.wikipedia.org/wiki/Snake_case). Don't use a combination of
191+
// camel case and snake case.
189192
//
190193
// Supported operations:
191194
//

0 commit comments

Comments
 (0)