Skip to content

Commit 59828ba

Browse files
authored
chore: add Go build targets for compute (#792)
Note: manually updated proto file, but it yields the same result of the new disco-converter would generate. Fixes: googleapis/google-cloud-go#7345
1 parent 9b19e9c commit 59828ba

3 files changed

Lines changed: 54 additions & 7 deletions

File tree

WORKSPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ gapic_generator_ruby_repositories()
464464
# Discovery
465465
##############################################################################
466466

467-
_disco_to_proto3_converter_version = "c47a76dd3d591478dd1a902413636c06da1153b8"
467+
_disco_to_proto3_converter_version = "96e1e63d3c1ddc546a57ac78b28893ee1013266a"
468468

469469
http_archive(
470470
name = "com_google_disco_to_proto3_converter",

google/cloud/compute/v1/BUILD.bazel

Lines changed: 52 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,25 +42,25 @@ _SERVICE_IGNORELIST = [
4242
proto_from_disco(
4343
name = "compute_gen",
4444
src = "compute.v1.json",
45-
previous_proto = "compute.proto",
4645
enums_as_strings = True,
4746
message_ignorelist = _MESSAGE_IGNORE_LIST,
47+
previous_proto = "compute.proto",
4848
service_ignorelist = _SERVICE_IGNORELIST,
4949
)
5050

5151
grpc_service_config_from_disco(
5252
name = "compute_grpc_service_config_gen",
5353
src = "compute.v1.json",
54-
previous_proto = "compute.proto",
5554
message_ignorelist = _MESSAGE_IGNORE_LIST,
55+
previous_proto = "compute.proto",
5656
service_ignorelist = _SERVICE_IGNORELIST,
5757
)
5858

5959
gapic_yaml_from_disco(
6060
name = "compute_gapic_gen",
6161
src = "compute.v1.json",
62-
previous_proto = "compute.proto",
6362
message_ignorelist = _MESSAGE_IGNORE_LIST,
63+
previous_proto = "compute.proto",
6464
service_ignorelist = _SERVICE_IGNORELIST,
6565
)
6666

@@ -308,8 +308,8 @@ nodejs_gapic_library(
308308
name = "compute_nodejs_gapic",
309309
package_name = "@google-cloud/compute",
310310
src = ":compute_proto_with_info",
311-
extra_protoc_parameters = ["metadata"],
312311
diregapic = True,
312+
extra_protoc_parameters = ["metadata"],
313313
deps = [],
314314
)
315315

@@ -366,7 +366,6 @@ ruby_gapic_assembly_pkg(
366366
],
367367
)
368368

369-
370369
##############################################################################
371370
# C#
372371
##############################################################################
@@ -411,3 +410,51 @@ csharp_gapic_assembly_pkg(
411410
":compute_csharp_proto",
412411
],
413412
)
413+
414+
##############################################################################
415+
# Go
416+
##############################################################################
417+
load(
418+
"@com_google_googleapis_imports//:imports.bzl",
419+
"go_gapic_assembly_pkg",
420+
"go_gapic_library",
421+
"go_proto_library",
422+
)
423+
424+
go_proto_library(
425+
name = "compute_go_proto",
426+
compilers = ["@io_bazel_rules_go//proto:go_grpc"],
427+
importpath = "cloud.google.com/go/compute/apiv1/computepb",
428+
protos = [":compute_proto"],
429+
deps = [
430+
"//google/api:annotations_go_proto",
431+
"//google/cloud:extended_operations_go_proto",
432+
],
433+
)
434+
435+
go_gapic_library(
436+
name = "compute_go_gapic",
437+
srcs = [":compute_proto_with_info"],
438+
grpc_service_config = "compute_grpc_service_config.json",
439+
importpath = "cloud.google.com/go/compute/apiv1;compute",
440+
metadata = True,
441+
release_level = "ga",
442+
rest_numeric_enums = False,
443+
service_yaml = "compute_v1.yaml",
444+
transport = "rest",
445+
deps = [
446+
":compute_go_proto",
447+
"@io_bazel_rules_go//proto/wkt:duration_go_proto",
448+
],
449+
)
450+
451+
# Open Source Packages
452+
go_gapic_assembly_pkg(
453+
name = "gapi-cloud-compute-v1-go",
454+
deps = [
455+
":compute_go_gapic",
456+
":compute_go_gapic_srcjar-metadata.srcjar",
457+
":compute_go_gapic_srcjar-test.srcjar",
458+
":compute_go_proto",
459+
],
460+
)

google/cloud/compute/v1/compute.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import "google/cloud/extended_operations.proto";
3232
// File Options
3333
//
3434
option csharp_namespace = "Google.Cloud.Compute.V1";
35-
option go_package = "google.golang.org/genproto/googleapis/cloud/compute/v1;compute";
35+
option go_package = "cloud.google.com/go/compute/apiv1/computepb";
3636
option java_multiple_files = true;
3737
option java_package = "com.google.cloud.compute.v1";
3838
option php_namespace = "Google\\Cloud\\Compute\\V1";

0 commit comments

Comments
 (0)