feat: deprecated the filter field and add resource_definition

Google APIs · copybara-github · commit 2bf9d8d49e07 · 2022-07-01T12:22:30.000-07:00
docs: add more meaningful comments

PiperOrigin-RevId: 458520697
diff --git a/google/cloud/dialogflow/v2/BUILD.bazel b/google/cloud/dialogflow/v2/BUILD.bazel
@@ -66,6 +66,7 @@ proto_library_with_info(
     deps = [
         ":dialogflow_proto",
         "//google/cloud:common_resources_proto",
+        "//google/cloud/location:location_proto",
     ],
 )
 
@@ -100,11 +101,13 @@ java_gapic_library(
     service_yaml = "dialogflow_v2.yaml",
     test_deps = [
         ":dialogflow_java_grpc",
+        "//google/cloud/location:location_java_grpc",
     ],
     transport = "grpc+rest",
     deps = [
         ":dialogflow_java_proto",
         "//google/api:api_java_proto",
+        "//google/cloud/location:location_java_proto",
     ],
 )
 
@@ -196,6 +199,7 @@ go_gapic_library(
     transport = "grpc+rest",
     deps = [
         ":dialogflow_go_proto",
+        "//google/cloud/location:location_go_proto",
         "//google/longrunning:longrunning_go_proto",
         "@com_google_cloud_go//longrunning:go_default_library",
         "@com_google_cloud_go//longrunning/autogen:go_default_library",
@@ -353,6 +357,7 @@ ruby_cloud_gapic_library(
     grpc_service_config = "dialogflow_grpc_service_config.json",
     ruby_cloud_description = "Dialogflow is an end-to-end, build-once deploy-everywhere development suite for creating conversational interfaces for websites, mobile applications, popular messaging platforms, and IoT devices. You can use it to build interfaces (such as chatbots and conversational IVR) that enable natural and rich interactions between your users and your business. This client is for Dialogflow ES, providing the standard agent type suitable for small and simple agents.",
     ruby_cloud_title = "Dialogflow V2",
+    service_yaml = "dialogflow_v2.yaml",
     deps = [
         ":dialogflow_ruby_grpc",
         ":dialogflow_ruby_proto",
diff --git a/google/cloud/dialogflow/v2/answer_record.proto b/google/cloud/dialogflow/v2/answer_record.proto
@@ -127,13 +127,16 @@ message ListAnswerRecordsRequest {
     }
   ];
 
-  // Required. Filters to restrict results to specific answer records.
-  // Filter on answer record type. Currently predicates on `type` is supported,
-  // valid values are `ARTICLE_ANSWER`, `FAQ_ANSWER`.
+  // Optional. Filters to restrict results to specific answer records.
+  //
+  // Marked deprecated as it hasn't been, and isn't currently, supported.
   //
   // For more information about filtering, see
   // [API Filtering](https://aip.dev/160).
-  string filter = 2 [(google.api.field_behavior) = REQUIRED];
+  string filter = 2 [
+    deprecated = true,
+    (google.api.field_behavior) = OPTIONAL
+  ];
 
   // Optional. The maximum number of records to return in a single page.
   // The server may return fewer records than this. If unspecified, we use 10.
diff --git a/google/cloud/dialogflow/v2/audio_config.proto b/google/cloud/dialogflow/v2/audio_config.proto
@@ -31,6 +31,10 @@ option (google.api.resource_definition) = {
   type: "automl.googleapis.com/Model"
   pattern: "projects/{project}/locations/{location}/models/{model}"
 };
+option (google.api.resource_definition) = {
+  type: "speech.googleapis.com/PhraseSet"
+  pattern: "projects/{project}/locations/{location}/phraseSets/{phrase_set}"
+};
 
 // Audio encoding of the audio content sent in the conversational query request.
 // Refer to the
diff --git a/google/cloud/dialogflow/v2/conversation_profile.proto b/google/cloud/dialogflow/v2/conversation_profile.proto
@@ -515,7 +515,8 @@ message HumanAgentAssistantConfig {
 
   // Custom conversation models used in agent assist feature.
   //
-  // Supported feature: ARTICLE_SUGGESTION, SMART_COMPOSE, SMART_REPLY.
+  // Supported feature: ARTICLE_SUGGESTION, SMART_COMPOSE, SMART_REPLY,
+  // CONVERSATION_SUMMARIZATION.
   message ConversationModelConfig {
     // Conversation model resource name. Format: `projects/<Project
     // ID>/conversationModels/<Model ID>`.
diff --git a/google/cloud/dialogflow/v2/dialogflow_v2.yaml b/google/cloud/dialogflow/v2/dialogflow_v2.yaml
@@ -21,6 +21,8 @@ apis:
 - name: google.cloud.dialogflow.v2.SessionEntityTypes
 - name: google.cloud.dialogflow.v2.Sessions
 - name: google.cloud.dialogflow.v2.Versions
+- name: google.cloud.location.Locations
+- name: google.longrunning.Operations
 
 types:
 - name: google.cloud.dialogflow.v2.BatchUpdateEntityTypesResponse
diff --git a/google/cloud/dialogflow/v2/session.proto b/google/cloud/dialogflow/v2/session.proto
@@ -324,7 +324,8 @@ message QueryResult {
   bool all_required_params_present = 5;
 
   // Indicates whether the conversational query triggers a cancellation for slot
-  // filling.
+  // filling. For more information, see the [cancel slot filling
+  // documentation](https://cloud.google.com/dialogflow/es/docs/intents-actions-parameters#cancel).
   bool cancels_slot_filling = 21;
 
   // The text to be pronounced to the user or shown on the screen.
@@ -608,6 +609,9 @@ message StreamingRecognitionResult {
   string language_code = 10;
 }
 
+// ============================================================================
+// Auxiliary proto messages.
+//
 // Represents the natural language text to be processed.
 message TextInput {
   // Required. The UTF-8 encoded natural language text to be processed.
