Skip to content

Commit 2bc2029

Browse files
Google APIscopybara-github
authored andcommitted
chore: deprecate legacy fields related to load balancing
docs: update comments for fields related to load balancing PiperOrigin-RevId: 618165773
1 parent 5ce591f commit 2bc2029

4 files changed

Lines changed: 18 additions & 18 deletions

File tree

google/cloud/networkmanagement/v1/connectivity_test.proto

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,6 @@ message Endpoint {
186186
}
187187

188188
// The IP address of the endpoint, which can be an external or internal IP.
189-
// An IPv6 address is only allowed when the test's destination is a
190-
// [global load balancer
191-
// VIP](https://cloud.google.com/load-balancing/docs/load-balancing-overview).
192189
string ip_address = 1;
193190

194191
// The IP protocol port of the endpoint.

google/cloud/networkmanagement/v1/trace.proto

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,10 @@ message Step {
124124
ARRIVE_AT_INSTANCE = 9;
125125

126126
// Forwarding state: arriving at a Compute Engine internal load balancer.
127-
ARRIVE_AT_INTERNAL_LOAD_BALANCER = 10;
127+
ARRIVE_AT_INTERNAL_LOAD_BALANCER = 10 [deprecated = true];
128128

129129
// Forwarding state: arriving at a Compute Engine external load balancer.
130-
ARRIVE_AT_EXTERNAL_LOAD_BALANCER = 11;
130+
ARRIVE_AT_EXTERNAL_LOAD_BALANCER = 11 [deprecated = true];
131131

132132
// Forwarding state: arriving at a Cloud VPN gateway.
133133
ARRIVE_AT_VPN_GATEWAY = 12;
@@ -223,8 +223,9 @@ message Step {
223223
// Display information of the final state "drop" and reason.
224224
DropInfo drop = 15;
225225

226-
// Display information of the load balancers.
227-
LoadBalancerInfo load_balancer = 16;
226+
// Display information of the load balancers. Deprecated in favor of the
227+
// `load_balancer_backend_info` field, not used in new tests.
228+
LoadBalancerInfo load_balancer = 16 [deprecated = true];
228229

229230
// Display information of a Google Cloud network.
230231
NetworkInfo network = 17;
@@ -626,8 +627,10 @@ message LoadBalancerInfo {
626627
// Type of the load balancer.
627628
LoadBalancerType load_balancer_type = 1;
628629

629-
// URI of the health check for the load balancer.
630-
string health_check_uri = 2;
630+
// URI of the health check for the load balancer. Deprecated and no longer
631+
// populated as different load balancer backends might have different health
632+
// checks.
633+
string health_check_uri = 2 [deprecated = true];
631634

632635
// Information for the loadbalancer backends.
633636
repeated LoadBalancerBackend backends = 3;

google/cloud/networkmanagement/v1beta1/connectivity_test.proto

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,6 @@ message Endpoint {
186186
}
187187

188188
// The IP address of the endpoint, which can be an external or internal IP.
189-
// An IPv6 address is only allowed when the test's destination is a
190-
// [global load balancer
191-
// VIP](https://cloud.google.com/load-balancing/docs/load-balancing-overview).
192189
string ip_address = 1;
193190

194191
// The IP protocol port of the endpoint.

google/cloud/networkmanagement/v1beta1/trace.proto

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,10 @@ message Step {
124124
ARRIVE_AT_INSTANCE = 9;
125125

126126
// Forwarding state: arriving at a Compute Engine internal load balancer.
127-
ARRIVE_AT_INTERNAL_LOAD_BALANCER = 10;
127+
ARRIVE_AT_INTERNAL_LOAD_BALANCER = 10 [deprecated = true];
128128

129129
// Forwarding state: arriving at a Compute Engine external load balancer.
130-
ARRIVE_AT_EXTERNAL_LOAD_BALANCER = 11;
130+
ARRIVE_AT_EXTERNAL_LOAD_BALANCER = 11 [deprecated = true];
131131

132132
// Forwarding state: arriving at a Cloud VPN gateway.
133133
ARRIVE_AT_VPN_GATEWAY = 12;
@@ -223,8 +223,9 @@ message Step {
223223
// Display information of the final state "drop" and reason.
224224
DropInfo drop = 15;
225225

226-
// Display information of the load balancers.
227-
LoadBalancerInfo load_balancer = 16;
226+
// Display information of the load balancers. Deprecated in favor of the
227+
// `load_balancer_backend_info` field, not used in new tests.
228+
LoadBalancerInfo load_balancer = 16 [deprecated = true];
228229

229230
// Display information of a Google Cloud network.
230231
NetworkInfo network = 17;
@@ -626,8 +627,10 @@ message LoadBalancerInfo {
626627
// Type of the load balancer.
627628
LoadBalancerType load_balancer_type = 1;
628629

629-
// URI of the health check for the load balancer.
630-
string health_check_uri = 2;
630+
// URI of the health check for the load balancer. Deprecated and no longer
631+
// populated as different load balancer backends might have different health
632+
// checks.
633+
string health_check_uri = 2 [deprecated = true];
631634

632635
// Information for the loadbalancer backends.
633636
repeated LoadBalancerBackend backends = 3;

0 commit comments

Comments
 (0)