feat: Clarify Batch API proto doc about pubsub notifications

Google APIs · copybara-github · commit 28b8748b79e3 · 2023-08-08T09:34:00.000-07:00
---
feat: add Batch Managed Container support for v1alpha
PiperOrigin-RevId: 554850516
diff --git a/google/cloud/batch/v1alpha/job.proto b/google/cloud/batch/v1alpha/job.proto
@@ -243,8 +243,12 @@ message ResourceUsage {
 // Notification configurations.
 message JobNotification {
   // Message details.
-  // Describe the attribute that a message should have.
-  // Without specified message attributes, no message will be sent by default.
+  // Describe the conditions under which messages will be sent.
+  // If no attribute is defined, no message will be sent by default.
+  // One message should specify either the job or the task level attributes,
+  // but not both. For example,
+  // job level: JOB_STATE_CHANGED and/or a specified new_job_state;
+  // task level: TASK_STATE_CHANGED and/or a specified new_task_state.
   message Message {
     // The message type.
     Type type = 1;
@@ -269,8 +273,8 @@ message JobNotification {
   }
 
   // The Pub/Sub topic where notifications like the job state changes
-  // will be published. This topic exist in the same project as the job
-  // and billings will be charged to this project.
+  // will be published. The topic must exist in the same project as
+  // the job and billings will be charged to this project.
   // If not specified, no Pub/Sub messages will be sent.
   // Topic format: `projects/{project}/topics/{topic}`.
   string pubsub_topic = 1;
diff --git a/google/cloud/batch/v1alpha/task.proto b/google/cloud/batch/v1alpha/task.proto
@@ -16,6 +16,7 @@ syntax = "proto3";
 
 package google.cloud.batch.v1alpha;
 
+import "google/api/field_behavior.proto";
 import "google/api/resource.proto";
 import "google/cloud/batch/v1alpha/volume.proto";
 import "google/protobuf/duration.proto";
@@ -156,6 +157,13 @@ message Runnable {
     // matches `projects/*/secrets/*/versions/*` then Batch will read the
     // password from the Secret Manager;
     string password = 11;
+
+    // Optional. Not yet implemented.
+    // If set to true, container will run with Image streaming.
+    // The container runtime will be changed to containerd
+    // instead of docker. Currently, only imageUri, commands, entrypoint
+    // and volumes are supported and any other fields will be ignored.
+    bool enable_image_streaming = 12 [(google.api.field_behavior) = OPTIONAL];
   }
 
   // Script runnable.
