Skip to content

Commit 28a44ec

Browse files
Google APIscopybara-github
authored andcommitted
chore: migrate maps/roads onto the {Java,Python} microgenerators
Committer: @miraleung PiperOrigin-RevId: 357770189
1 parent 38d77ab commit 28a44ec

3 files changed

Lines changed: 22 additions & 71 deletions

File tree

google/maps/roads/v1op/BUILD.bazel

Lines changed: 15 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,14 @@ proto_library_with_info(
3434

3535
##############################################################################
3636
# Java
37-
# DO NOT OVERRIDE with autogenerated rules if NOT migrated to Java Microgen
3837
##############################################################################
3938
load(
4039
"@com_google_googleapis_imports//:imports.bzl",
40+
"java_gapic_assembly_gradle_pkg",
41+
"java_gapic_library",
42+
"java_gapic_test",
4143
"java_grpc_library",
4244
"java_proto_library",
43-
java_gapic_assembly_gradle_pkg = "java_gapic_assembly_gradle_pkg_legacy",
44-
java_gapic_library = "java_gapic_library_legacy",
45-
java_gapic_test = "java_gapic_test_legacy",
4645
)
4746

4847
java_proto_library(
@@ -58,10 +57,9 @@ java_grpc_library(
5857

5958
java_gapic_library(
6059
name = "roads_java_gapic",
61-
src = ":roads_proto_with_info",
60+
srcs = [":roads_proto_with_info"],
6261
gapic_yaml = "roads_gapic.yaml",
63-
package = "google.maps.roads.v1op",
64-
service_yaml = "roads_v1op.yaml",
62+
grpc_service_config = "roads_grpc_service_config.json",
6563
test_deps = [
6664
":roads_java_grpc",
6765
],
@@ -70,6 +68,12 @@ java_gapic_library(
7068
],
7169
)
7270

71+
java_gapic_test(
72+
name = "roads_java_gapic_test_suite",
73+
test_classes = ["com.google.maps.roads.v1op.RoadsServiceClientTest"],
74+
runtime_deps = ["roads_java_gapic_test"],
75+
)
76+
7377
# Open Source Packages
7478
java_gapic_assembly_gradle_pkg(
7579
name = "google-maps-roads-v1op-java",
@@ -139,47 +143,24 @@ go_gapic_assembly_pkg(
139143

140144
##############################################################################
141145
# Python
142-
# DO NOT OVERRIDE with autogenerated rules if NOT migrated to Python Microgen
143146
##############################################################################
144147
load(
145148
"@com_google_googleapis_imports//:imports.bzl",
146-
"py_grpc_library",
147-
"py_proto_library",
148-
py_gapic_assembly_pkg = "py_gapic_assembly_pkg_legacy",
149-
py_gapic_library = "py_gapic_library_legacy",
150-
)
151-
152-
py_proto_library(
153-
name = "roads_py_proto",
154-
plugin = "@protoc_docs_plugin//:docs_plugin",
155-
deps = [":roads_proto"],
156-
)
157-
158-
py_grpc_library(
159-
name = "roads_py_grpc",
160-
srcs = [":roads_proto"],
161-
deps = [":roads_py_proto"],
149+
"py_gapic_assembly_pkg",
150+
"py_gapic_library",
162151
)
163152

164153
py_gapic_library(
165154
name = "roads_py_gapic",
166-
src = ":roads_proto_with_info",
167-
gapic_yaml = "roads_gapic.yaml",
168-
package = "google.maps.roads.v1op",
169-
service_yaml = "roads_v1op.yaml",
170-
deps = [
171-
":roads_py_grpc",
172-
":roads_py_proto",
173-
],
155+
srcs = [":roads_proto"],
156+
grpc_service_config = "roads_grpc_service_config.json",
174157
)
175158

176159
# Open Source Packages
177160
py_gapic_assembly_pkg(
178161
name = "roads-v1op-py",
179162
deps = [
180163
":roads_py_gapic",
181-
":roads_py_grpc",
182-
":roads_py_proto",
183164
],
184165
)
185166

google/maps/roads/v1op/roads.proto

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,16 @@ service RoadsService {
3333
// This method takes a sequence of latitude,longitude points and snaps them to
3434
// the most likely road segments. Optionally returns additional points giving
3535
// the full road geometry. Also returns a place ID for each snapped point.
36-
rpc SnapToRoads(SnapToRoadsRequest) returns (SnapToRoadsResponse) {}
36+
rpc SnapToRoads(SnapToRoadsRequest) returns (SnapToRoadsResponse) {
37+
option (google.api.method_signature) = "path";
38+
}
3739

3840
// This method takes a list of latitude,longitude points and snaps them each
3941
// to their nearest road. Also returns a place ID for each snapped point.
4042
rpc ListNearestRoads(ListNearestRoadsRequest)
41-
returns (ListNearestRoadsResponse) {}
43+
returns (ListNearestRoadsResponse) {
44+
option (google.api.method_signature) = "points";
45+
}
4246
}
4347

4448
// A request to the SnapToRoads method, requesting that a sequence of points be
Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
type: com.google.api.codegen.ConfigProto
2-
config_schema_version: 1.0.0
2+
config_schema_version: 2.0.0
33
language_settings:
4-
java:
5-
package_name: com.google.maps.roads.v1op
64
python:
75
package_name: google.maps.roads.v1op.gapic
86
go:
@@ -16,35 +14,3 @@ language_settings:
1614
nodejs:
1715
package_name: roads.v1op
1816
domain_layer_location: googlemaps # becomes @googlemaps/roads
19-
interfaces:
20-
- name: google.maps.roads.v1op.RoadsService
21-
collections: []
22-
retry_codes_def:
23-
- name: idempotent
24-
retry_codes:
25-
- UNAVAILABLE
26-
- DEADLINE_EXCEEDED
27-
- name: non_idempotent
28-
retry_codes: []
29-
retry_params_def:
30-
- name: default
31-
initial_retry_delay_millis: 100
32-
retry_delay_multiplier: 1.3
33-
max_retry_delay_millis: 60000
34-
initial_rpc_timeout_millis: 60000
35-
rpc_timeout_multiplier: 1
36-
max_rpc_timeout_millis: 60000
37-
total_timeout_millis: 600000
38-
methods:
39-
- name: SnapToRoads
40-
required_fields:
41-
- path
42-
retry_codes_name: idempotent
43-
retry_params_name: default
44-
timeout_millis: 60000
45-
- name: ListNearestRoads
46-
required_fields:
47-
- points
48-
retry_codes_name: idempotent
49-
retry_params_name: default
50-
timeout_millis: 60000

0 commit comments

Comments
 (0)