Skip to content

Commit 22d2bda

Browse files
Google APIscopybara-github
authored andcommitted
docs: clarified gcs_bucket field of the SecuritySettings message
PiperOrigin-RevId: 477778532
1 parent 57062cd commit 22d2bda

2 files changed

Lines changed: 24 additions & 14 deletions

File tree

google/cloud/dialogflow/cx/v3beta1/BUILD.bazel

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ java_gapic_library(
9696
srcs = [":cx_proto_with_info"],
9797
gapic_yaml = None,
9898
grpc_service_config = "dialogflow_grpc_service_config.json",
99+
rest_numeric_enums = False,
99100
service_yaml = "dialogflow_v3beta1.yaml",
100101
test_deps = [
101102
":cx_java_grpc",
@@ -191,6 +192,7 @@ go_gapic_library(
191192
grpc_service_config = "dialogflow_grpc_service_config.json",
192193
importpath = "cloud.google.com/go/dialogflow/cx/apiv3beta1;cx",
193194
metadata = True,
195+
rest_numeric_enums = False,
194196
service_yaml = "dialogflow_v3beta1.yaml",
195197
transport = "grpc+rest",
196198
deps = [
@@ -229,6 +231,7 @@ load(
229231
"@com_google_googleapis_imports//:imports.bzl",
230232
"py_gapic_assembly_pkg",
231233
"py_gapic_library",
234+
"py_test",
232235
)
233236

234237
py_gapic_library(
@@ -239,20 +242,23 @@ py_gapic_library(
239242
"python-gapic-name=dialogflowcx",
240243
"python-gapic-namespace=google.cloud",
241244
],
245+
rest_numeric_enums = False,
242246
service_yaml = "dialogflow_v3beta1.yaml",
243247
transport = "grpc",
248+
deps = [
249+
],
244250
)
245251

246252
# Uncomment once https://github.com/googleapis/gapic-generator-python/issues/1376 is fixed
247-
#py_test(
248-
# name = "cx_py_gapic_test",
249-
# srcs = [
250-
# "cx_py_gapic_pytest.py",
251-
# "cx_py_gapic_test.py",
252-
# ],
253-
# legacy_create_init = False,
254-
# deps = [":cx_py_gapic"],
255-
#)
253+
# py_test(
254+
# name = "cx_py_gapic_test",
255+
# srcs = [
256+
# "cx_py_gapic_pytest.py",
257+
# "cx_py_gapic_test.py",
258+
# ],
259+
# legacy_create_init = False,
260+
# deps = [":cx_py_gapic"],
261+
# )
256262

257263
# Open Source Packages
258264
py_gapic_assembly_pkg(
@@ -288,6 +294,7 @@ php_gapic_library(
288294
name = "cx_php_gapic",
289295
srcs = [":cx_proto_with_info"],
290296
grpc_service_config = "dialogflow_grpc_service_config.json",
297+
rest_numeric_enums = False,
291298
service_yaml = "dialogflow_v3beta1.yaml",
292299
deps = [
293300
":cx_php_grpc",
@@ -321,9 +328,9 @@ nodejs_gapic_library(
321328
extra_protoc_parameters = ["metadata"],
322329
grpc_service_config = "dialogflow_grpc_service_config.json",
323330
package = "google.cloud.dialogflow.cx.v3beta1",
331+
rest_numeric_enums = False,
324332
service_yaml = "dialogflow_v3beta1.yaml",
325333
deps = [],
326-
mixins = "google.longrunning.Operations;google.cloud.location.Locations",
327334
)
328335

329336
nodejs_gapic_assembly_pkg(
@@ -368,6 +375,7 @@ ruby_cloud_gapic_library(
368375
"ruby-cloud-product-url=https://cloud.google.com/dialogflow",
369376
],
370377
grpc_service_config = "dialogflow_grpc_service_config.json",
378+
rest_numeric_enums = False,
371379
ruby_cloud_description = "Dialogflow is an end-to-end, build-once deploy-everywhere development suite for creating conversational interfaces for websites, mobile applications, popular messaging platforms, and IoT devices. You can use it to build interfaces (such as chatbots and conversational IVR) that enable natural and rich interactions between your users and your business. This client is for Dialogflow CX, providing an advanced agent type suitable for large or very complex agents.",
372380
ruby_cloud_title = "Dialogflow CX V3beta1",
373381
service_yaml = "dialogflow_v3beta1.yaml",
@@ -414,6 +422,7 @@ csharp_gapic_library(
414422
srcs = [":cx_proto_with_info"],
415423
common_resources_config = "@gax_dotnet//:Google.Api.Gax/ResourceNames/CommonResourcesConfig.json",
416424
grpc_service_config = "dialogflow_grpc_service_config.json",
425+
rest_numeric_enums = False,
417426
service_yaml = "dialogflow_v3beta1.yaml",
418427
deps = [
419428
":cx_csharp_grpc",

google/cloud/dialogflow/cx/v3beta1/security_settings.proto

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,10 +231,11 @@ message SecuritySettings {
231231
OGG = 3;
232232
}
233233

234-
// Cloud Storage bucket to export audio record to. You need to grant
235-
// `service-<Conversation Project
236-
// Number>@gcp-sa-dialogflow.iam.gserviceaccount.com` the `Storage Object
237-
// Admin` role in this bucket.
234+
// Cloud Storage bucket to export audio record to.
235+
// Setting this field would grant the Storage Object Creator role to
236+
// the Dialogflow Service Agent.
237+
// API caller that tries to modify this field should have the permission of
238+
// storage.buckets.setIamPolicy.
238239
string gcs_bucket = 1;
239240

240241
// Filename pattern for exported audio.

0 commit comments

Comments
 (0)