fix!: Remove DiscoverConnectionProfile method signature which didn't populate the request sufficiently

Google APIs · copybara-github · commit 125799dc997a · 2021-06-30T09:03:41.000-07:00
fix!: Overhaul resource annotations, some of which were incorrect and some of which were just non-ideal

PiperOrigin-RevId: 382316023
diff --git a/google/cloud/datastream/v1alpha1/datastream.proto b/google/cloud/datastream/v1alpha1/datastream.proto
@@ -96,13 +96,12 @@ service Datastream {
   // Use this method to discover a connection profile.
   // The discover API call exposes the data objects and metadata belonging to
   // the profile. Typically, a request returns children data objects under a
-  // parent data object that’s optionally supplied in the request.
+  // parent data object that's optionally supplied in the request.
   rpc DiscoverConnectionProfile(DiscoverConnectionProfileRequest) returns (DiscoverConnectionProfileResponse) {
     option (google.api.http) = {
       post: "/v1alpha1/{parent=projects/*/locations/*}/connectionProfiles:discover"
       body: "*"
     };
-    option (google.api.method_signature) = "parent";
   }
 
   // Use this method to list streams in a project and location.
@@ -173,7 +172,7 @@ service Datastream {
 
   // The FetchStaticIps API call exposes the static ips used by Datastream.
   // Typically, a request returns children data objects under
-  // a parent data object that’s optionally supplied in the request.
+  // a parent data object that's optionally supplied in the request.
   rpc FetchStaticIps(FetchStaticIpsRequest) returns (FetchStaticIpsResponse) {
     option (google.api.http) = {
       get: "/v1alpha1/{name=projects/*/locations/*}:fetchStaticIps"
@@ -274,7 +273,7 @@ message DiscoverConnectionProfileRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "locations.googleapis.com/Location"
+      child_type: "datastream.googleapis.com/ConnectionProfile"
     }
   ];
 
@@ -415,7 +414,7 @@ message CreateConnectionProfileRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "datastream.googleapis.com/ConnectionProfile"
+      child_type: "datastream.googleapis.com/ConnectionProfile"
     }
   ];
 
@@ -548,7 +547,7 @@ message CreateStreamRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "datastream.googleapis.com/Stream"
+      child_type: "datastream.googleapis.com/Stream"
     }
   ];
 
@@ -675,7 +674,7 @@ message CreatePrivateConnectionRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "locations.googleapis.com/Location"
+      child_type: "datastream.googleapis.com/PrivateConnection"
     }
   ];
 
@@ -706,7 +705,7 @@ message ListPrivateConnectionsRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "locations.googleapis.com/Location"
+      child_type: "datastream.googleapis.com/PrivateConnection"
     }
   ];
 
@@ -748,7 +747,7 @@ message DeletePrivateConnectionRequest {
   string name = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "locations.googleapis.com/Location"
+      type: "datastream.googleapis.com/PrivateConnection"
     }
   ];
 
@@ -777,7 +776,7 @@ message GetPrivateConnectionRequest {
   string name = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "locations.googleapis.com/Location"
+      type: "datastream.googleapis.com/PrivateConnection"
     }
   ];
 }
@@ -788,7 +787,7 @@ message CreateRouteRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "datastream.googleapis.com/PrivateConnection"
+      child_type: "datastream.googleapis.com/Route"
     }
   ];
 
@@ -820,7 +819,7 @@ message ListRoutesRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "datastream.googleapis.com/PrivateConnection"
+      child_type: "datastream.googleapis.com/Route"
     }
   ];
 
@@ -864,7 +863,7 @@ message DeleteRouteRequest {
   string name = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "datastream.googleapis.com/PrivateConnection"
+      type: "datastream.googleapis.com/Route"
     }
   ];
 
@@ -890,7 +889,7 @@ message GetRouteRequest {
   string name = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "datastream.googleapis.com/PrivateConnection"
+      type: "datastream.googleapis.com/Route"
     }
   ];
 }
diff --git a/google/cloud/datastream/v1alpha1/datastream_resources.proto b/google/cloud/datastream/v1alpha1/datastream_resources.proto
@@ -508,7 +508,7 @@ message Stream {
     pattern: "projects/{project}/locations/{location}/streams/{stream}"
   };
 
-  // Backfill strategy to automatically backfill the Stream’s objects.
+  // Backfill strategy to automatically backfill the Stream's objects.
   // Specific objects can be excluded.
   message BackfillAllStrategy {
     // List of objects to exclude.
@@ -521,7 +521,7 @@ message Stream {
     }
   }
 
-  // Backfill strategy to disable automatic backfill for the Stream’s objects.
+  // Backfill strategy to disable automatic backfill for the Stream's objects.
   message BackfillNoneStrategy {
 
   }
diff --git a/google/cloud/datastream/v1alpha1/datastream_v1alpha1.yaml b/google/cloud/datastream/v1alpha1/datastream_v1alpha1.yaml
@@ -1,7 +1,7 @@
 type: google.api.Service
 config_version: 3
 name: datastream.googleapis.com
-title: DataStream API
+title: Datastream API
 
 apis:
 - name: google.cloud.datastream.v1alpha1.Datastream
@@ -25,7 +25,7 @@ backend:
   - selector: 'google.cloud.datastream.v1alpha1.Datastream.*'
     deadline: 60.0
   - selector: google.cloud.datastream.v1alpha1.Datastream.DiscoverConnectionProfile
-    deadline: 90.0
+    deadline: 120.0
   - selector: google.cloud.location.Locations.GetLocation
     deadline: 60.0
   - selector: google.cloud.location.Locations.ListLocations

Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,7 @@ message Stream {`
`508`	`508`	`pattern: "projects/{project}/locations/{location}/streams/{stream}"`
`509`	`509`	`};`
`510`	`510`
`511`		`- // Backfill strategy to automatically backfill the Stream’s objects.`
	`511`	`+ // Backfill strategy to automatically backfill the Stream's objects.`
`512`	`512`	`// Specific objects can be excluded.`
`513`	`513`	`message BackfillAllStrategy {`
`514`	`514`	`// List of objects to exclude.`
`@@ -521,7 +521,7 @@ message Stream {`
`521`	`521`	`}`
`522`	`522`	`}`
`523`	`523`
`524`		`- // Backfill strategy to disable automatic backfill for the Stream’s objects.`
	`524`	`+ // Backfill strategy to disable automatic backfill for the Stream's objects.`
`525`	`525`	`message BackfillNoneStrategy {`
`526`	`526`
`527`	`527`	`}`