feat: Add tags field in Job's AllocationPolicy field in v1alpha

Google APIs · copybara-github · commit 09b78e202a85 · 2024-01-08T17:08:37.000-08:00
feat: add a run_as_non_root field and deprecate enable_oslogin for non-root execution
docs: updated comments

PiperOrigin-RevId: 596742590
diff --git a/google/cloud/batch/v1alpha/job.proto b/google/cloud/batch/v1alpha/job.proto
@@ -608,6 +608,13 @@ message AllocationPolicy {
 
   // The placement policy.
   PlacementPolicy placement = 10;
+
+  // Optional. Tags applied to the VM instances.
+  //
+  // The tags identify valid sources or targets for network firewalls.
+  // Each tag must be 1-63 characters long, and comply with
+  // [RFC1035](https://www.ietf.org/rfc/rfc1035.txt).
+  repeated string tags = 11 [(google.api.field_behavior) = OPTIONAL];
 }
 
 // A TaskGroup defines one or more Tasks that all share the same TaskSpec.
@@ -692,16 +699,23 @@ message TaskGroup {
   // VMs running the Batch tasks in the same TaskGroup.
   bool permissive_ssh = 12;
 
-  // Optional. When true, Batch will use the OS Login generated POSIX account to
-  // exeucute the runnables instead of the default root user.
+  // Optional. Deprecated: When true, Batch will use the OS Login generated
+  // POSIX account to exeucute the runnables instead of the default root user.
   //
   // To control root or non-root privilege for runnable execution, the project \
   // Admin user needs to configure IAM roles according to
   // https://cloud.google.com/compute/docs/oslogin/set-up-oslogin#configure_users.
   // Specifically, if a root execution is needed, the roles/compute.osAdminLogin
   // should be granted to the Batch job submitter. Otherwise,
   // roles/compute.osLogin should be granted to the Batch job submitter.
-  bool enable_oslogin = 13 [(google.api.field_behavior) = OPTIONAL];
+  bool enable_oslogin = 13
+      [deprecated = true, (google.api.field_behavior) = OPTIONAL];
+
+  // Optional. If not set or set to false, Batch will use root user to execute
+  // runnables. If set to true, Batch will make sure to run the runnables using
+  // non-root user. Currently, the non-root user Batch used is generated by OS
+  // login. Reference: https://cloud.google.com/compute/docs/oslogin
+  bool run_as_non_root = 14 [(google.api.field_behavior) = OPTIONAL];
 }
 
 // Carries information about a Google Cloud service account.
diff --git a/google/cloud/batch/v1alpha/task.proto b/google/cloud/batch/v1alpha/task.proto
@@ -208,11 +208,13 @@ message Runnable {
     // password from the Secret Manager;
     string password = 11;
 
-    // Optional. Not yet implemented.
-    // If set to true, container will run with Image streaming.
+    // Optional. If set to true, container will run with Image streaming.
     // The container runtime will be changed to containerd
     // instead of docker. Currently, only imageUri, commands, entrypoint
     // and volumes are supported and any other fields will be ignored.
+    // Please refer
+    // [here](https://github.com/GoogleCloudPlatform/batch-samples/tree/main/api-samples/image-streaming)
+    // for the feature requirements and limitations.
     bool enable_image_streaming = 12 [(google.api.field_behavior) = OPTIONAL];
   }
 
