feat: exposing EntrySource.location field that contains location of a resource in the source system

Google APIs · copybara-github · commit 05fb262bddfb · 2024-06-17T09:20:43.000-07:00
---
docs: Scrub descriptions for GenerateDataQualityRules
PiperOrigin-RevId: 644032512
diff --git a/google/cloud/dataplex/v1/catalog.proto b/google/cloud/dataplex/v1/catalog.proto
@@ -713,6 +713,12 @@ message EntrySource {
 
   // The update time of the resource in the source system.
   google.protobuf.Timestamp update_time = 11;
+
+  // Output only. Location of the resource in the source system. Entry will be
+  // searchable by this location. By default, this should match the location of
+  // the EntryGroup containing this entry. A different value allows capturing
+  // source location for data external to GCP.
+  string location = 12 [(google.api.field_behavior) = OUTPUT_ONLY];
 }
 
 // Create EntryGroup Request
diff --git a/google/cloud/dataplex/v1/datascans.proto b/google/cloud/dataplex/v1/datascans.proto
@@ -126,7 +126,10 @@ service DataScanService {
     option (google.api.method_signature) = "parent";
   }
 
-  // Generates recommended DataQualityRule from a data profiling DataScan.
+  // Generates recommended data quality rules based on the results of a data
+  // profiling scan.
+  //
+  // Use the recommendations to build rules for a data quality scan.
   rpc GenerateDataQualityRules(GenerateDataQualityRulesRequest)
       returns (GenerateDataQualityRulesResponse) {
     option (google.api.http) = {
@@ -381,18 +384,21 @@ message ListDataScanJobsResponse {
   string next_page_token = 2;
 }
 
-// Generate recommended DataQualityRules request.
+// Request details for generating data quality rule recommendations.
 message GenerateDataQualityRulesRequest {
-  // Required. The name should be either
-  // * the name of a datascan with at least one successful completed data
-  // profiling job, or
-  // * the name of a successful completed data profiling datascan job.
+  // Required. The name must be one of the following:
+  //
+  // * The name of a data scan with at least one successful, completed data
+  // profiling job
+  // * The name of a successful, completed data profiling job (a data scan job
+  // where the job type is data profiling)
   string name = 1 [(google.api.field_behavior) = REQUIRED];
 }
 
-// Generate recommended DataQualityRules response.
+// Response details for data quality rule recommendations.
 message GenerateDataQualityRulesResponse {
-  // Generated recommended {@link DataQualityRule}s.
+  // The data quality rules that Dataplex generates based on the results
+  // of a data profiling scan.
   repeated DataQualityRule rule = 1;
 }
 
