Skip to content

Commit 0333730

Browse files
Google APIscopybara-github
Google APIs
authored and
copybara-github
committed
feat: add a install_ops_agent field to InstancePolicyOrTemplate for Ops Agent support
--- docs:Add instructions on how to configure cross-project pubsub publisher --- docs: document default disk type: pd-standard for non boot disk, pd-balanced for boot disk --- docs: Update list of volume.mount_options field --- docs: Update GCS description of volume.mount_options field --- docs: Update links in the description of volume.mount_options field PiperOrigin-RevId: 646638165
1 parent a0eb8ce commit 0333730

2 files changed

Lines changed: 33 additions & 15 deletions

File tree

‎google/cloud/batch/v1/job.proto‎

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -233,11 +233,19 @@ message JobNotification {
233233
TASK_STATE_CHANGED = 2;
234234
}
235235

236-
// The Pub/Sub topic where notifications like the job state changes
237-
// will be published. The topic must exist in the same project as
238-
// the job and billings will be charged to this project.
239-
// If not specified, no Pub/Sub messages will be sent.
240-
// Topic format: `projects/{project}/topics/{topic}`.
236+
// The Pub/Sub topic where notifications for the job, like state
237+
// changes, will be published. If undefined, no Pub/Sub notifications
238+
// are sent for this job.
239+
//
240+
// Specify the topic using the following format:
241+
// `projects/{project}/topics/{topic}`.
242+
// Notably, if you want to specify a Pub/Sub topic that is in a
243+
// different project than the job, your administrator must grant your
244+
// project's Batch service agent permission to publish to that topic.
245+
//
246+
// For more information about configuring Pub/Sub notifications for
247+
// a job, see
248+
// https://cloud.google.com/batch/docs/enable-notifications.
241249
string pubsub_topic = 1;
242250

243251
// The attribute requirements of messages to be sent to this Pub/Sub topic.
@@ -299,7 +307,9 @@ message AllocationPolicy {
299307
// Disk type as shown in `gcloud compute disk-types list`.
300308
// For example, local SSD uses type "local-ssd".
301309
// Persistent disks and boot disks use "pd-balanced", "pd-extreme", "pd-ssd"
302-
// or "pd-standard".
310+
// or "pd-standard". If not specified, "pd-standard" will be used as the
311+
// default type for non-boot disks, "pd-balanced" will be used as the
312+
// default type for boot disks.
303313
string type = 1;
304314

305315
// Disk size in GB.
@@ -430,6 +440,10 @@ message AllocationPolicy {
430440
// non Container-Optimized Image cases, following
431441
// https://github.com/GoogleCloudPlatform/compute-gpu-installation/blob/main/linux/install_gpu_driver.py.
432442
bool install_gpu_drivers = 3;
443+
444+
// Optional. Set this field true if you want Batch to install Ops Agent on
445+
// your behalf. Default is false.
446+
bool install_ops_agent = 4 [(google.api.field_behavior) = OPTIONAL];
433447
}
434448

435449
// A network interface.

‎google/cloud/batch/v1/volume.proto‎

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,19 @@ message Volume {
4747
// The mount path for the volume, e.g. /mnt/disks/share.
4848
string mount_path = 4;
4949

50-
// For Google Cloud Storage (GCS), mount options are the options supported by
51-
// the gcsfuse tool (https://github.com/GoogleCloudPlatform/gcsfuse).
52-
// For existing persistent disks, mount options provided by the
53-
// mount command (https://man7.org/linux/man-pages/man8/mount.8.html) except
54-
// writing are supported. This is due to restrictions of multi-writer mode
55-
// (https://cloud.google.com/compute/docs/disks/sharing-disks-between-vms).
56-
// For other attached disks and Network File System (NFS), mount options are
57-
// these supported by the mount command
58-
// (https://man7.org/linux/man-pages/man8/mount.8.html).
50+
// Mount options vary based on the type of storage volume:
51+
//
52+
// * For a Cloud Storage bucket, all the mount options provided
53+
// by
54+
// the [`gcsfuse` tool](https://cloud.google.com/storage/docs/gcsfuse-cli)
55+
// are supported.
56+
// * For an existing persistent disk, all mount options provided by the
57+
// [`mount` command](https://man7.org/linux/man-pages/man8/mount.8.html)
58+
// except writing are supported. This is due to restrictions of
59+
// [multi-writer
60+
// mode](https://cloud.google.com/compute/docs/disks/sharing-disks-between-vms).
61+
// * For any other disk or a Network File System (NFS), all the
62+
// mount options provided by the `mount` command are supported.
5963
repeated string mount_options = 5;
6064
}
6165

0 commit comments

Comments
 (0)