Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore(librarian): onboard to librarian#486

Merged
parthea merged 4 commits intomainfrom
onboard-librarian
Nov 11, 2025
Merged

chore(librarian): onboard to librarian#486
parthea merged 4 commits intomainfrom
onboard-librarian

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Nov 7, 2025 •
edited
Loading

Towards googleapis/librarian#2454

Blocked on #485

@parthea parthea requested review from a team November 7, 2025 16:37
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/google-resumable-media-python API. labels Nov 7, 2025
vchudnov-g
vchudnov-g previously approved these changes Nov 10, 2025
View reviewed changes
Comment thread .librarian/state.yaml
@@ -0,0 +1,10 @@
image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
Copy link
Copy Markdown

@vchudnov-g vchudnov-g Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When should we update this SHA? How? Maybe include a comment here or in a README.

Copy link
Copy Markdown
Contributor Author

@parthea parthea Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason to update the SHA is when there is a specific feature or fix which is only available in a newer image. This is similar to any dependency update. In this case, this SHA is the first version of the python-librarian-generator to support librarian version 1.0.0 which was just released. https://github.com/googleapis/librarian/releases/tag/v1.0.0

Use the instructions here to update the SHA: https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#pin-the-language-container-version-in-stateyaml

librarian update-image -image=us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620

@parthea parthea merged commit 54a56f1 into main Nov 11, 2025
18 checks passed
@parthea parthea deleted the onboard-librarian branch November 11, 2025 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ohmayr ohmayr ohmayr approved these changes

@vchudnov-g vchudnov-g vchudnov-g left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@BrennaEpp BrennaEpp

Labels

api: storage Issues related to the googleapis/google-resumable-media-python API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@parthea @vchudnov-g @ohmayr @BrennaEpp