This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix(resumable-media): fix failing unit tests by dropping Python 3.4, add Python 3.8#118
Merged
plamut merged 6 commits intogoogleapis:masterfrom Jan 9, 2020
Merged
fix(resumable-media): fix failing unit tests by dropping Python 3.4, add Python 3.8#118plamut merged 6 commits intogoogleapis:masterfrom
plamut merged 6 commits intogoogleapis:masterfrom
Conversation
With the Python <=3.4 support dropped, byte string templates can be used, hooray!
googlebot
added
the
cla: yes
busunkim96
reviewed
Jan 8, 2020
|
|
||
|
|
||
| @nox.session(python=['2.7', '3.4', '3.5', '3.6', '3.7']) | ||
| @nox.session(python=['3.5', '3.6', '3.7']) |
Contributor
There was a problem hiding this comment.
Would you mind dropping 3.8 in here as well?
Contributor
Author
There was a problem hiding this comment.
Done.
I also bumped the Python versions in other sessions to 3.8, as I believe this a standard practice (running misc. checks with the latest supported version).
Contributor
|
Before removing python 2.7 from resumable media we would need to remove it from |
Contributor
Author
|
I can revert dropping Python 2.7, that commit that introduced a byte string template is optional. Yes, I can add Python 3.8, too. |
THis is needed to retain Python 2.7 support for a little longer
plamut
changed the title
crwilcox
approved these changes
Jan 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117.