This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: add raw download classes#109
Merged
tseaver merged 12 commits intogoogleapis:masterfrom Oct 28, 2019
tseaver:106-add-raw-download-classes
Merged
feat: add raw download classes#109tseaver merged 12 commits intogoogleapis:masterfrom tseaver:106-add-raw-download-classes
tseaver merged 12 commits intogoogleapis:masterfrom
tseaver:106-add-raw-download-classes
Conversation
Always reads the raw stream content to compute a response body.
Performs download using raw response stream.
Performs chunked download using raw response stream.
Move the 'test_corrupt_download` test there, as only raw downloads preserve the actual MD5 hash of the file when content encoding is present.
Move formerly-failing 'test_chunked_download' test there, becuase the non-raw version cannot succeed for content-encoded resources due to requests' expansion.
googlebot
added
the
cla: yes
Contributor
Author
|
I have verified that the |
Contributor
Author
|
@crwilcox PTAL |
crwilcox
reviewed
Oct 25, 2019
crwilcox
approved these changes
Oct 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores "raw download" behavior as separate
RawDownloadandRawChunkedDownloadclasses: the existingDownloadandChunkedDownloadclasses retain their bad-but-backward-compatible behavior of expanding resources withContent-Encodingheaders set.Closes #106.