Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

deflate-encoded content will fail md5 checksum #37

@mfschwartz

Description

@mfschwartz

#36 fixes the problem of MD5 checksum failures when content was stored with content-encoding:gzip, but we will have a similar problem for content with content-encoding:deflate because that fix only monkey patches the decoder for the gzip case.

Two options:

  1. Change accept-encoding to only be "gzip", rather than "gzip, deflate"
  2. Broaden the monkey patch approach started in pull/36 to support deflate as well.

(Side note: I've read that deflate is somewhat more CPU efficient than gzip, which I think is more of a concern for browsers in general.)

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.downloadpriority: p2Moderately-important priority. Fix may not be included in next release.requests-transporttype: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions