Repository navigation
chore: update librarian and regenerate qualified To/FromProto - #7374
Conversation
Regenerates prost conversion and gRPC transport modules across google-cloud-bigquery, google-cloud-firestore, google-cloud-gax-internal, google-cloud-pubsub, google-cloud-spanner, google-cloud-storage, google-cloud-test-macros, and 18 generated gRPC client crates to qualify gaxi::prost::ToProto::<T>::to_proto calls with their target prost types. For googleapis#7284
suzmue
added
the
do not merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request systematically updates the auto-generated conversion and transport code across multiple crates to use explicit, fully qualified ToProto::::to_proto trait method calls instead of generic .to_proto() method calls. This change resolves potential trait resolution ambiguities and ensures type-safe serialization across services such as BigQuery, Firestore, Pub/Sub, Spanner, Storage, and others. I have no additional feedback to provide as these changes are consistent and correct.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7374 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 334 334
Lines 147687 147687
=======================================
Hits 145719 145719
Misses 1968 1968 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Regenerates prost conversion modules to qualify generated gaxi::prost::FromProto calls with their target model types, using the librarian change in googleapis/librarian qualify-fromproto. For googleapis#7284
suzmue
removed
the
do not merge
suzmue
changed the title
Regenerates prost conversions to use fully qualified syntax.
For #7284