Repository navigation
feat(storage): add connect and read timeouts - #7349
alex-hunt-materialize wants to merge 5 commits into
Conversation
product-auto-label
Bot
added
the
api: storage
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring connection and read timeouts on HTTP requests within the Google Cloud Rust SDK. Specifically, it adds connect_timeout and read_timeout options to the client builder configurations, integrates them into the underlying ReqwestClient in google-cloud-gax-internal, and exposes them via the ClientBuilder in google-cloud-storage. Additionally, corresponding tests and documentation examples are added. Feedback on the changes suggests avoiding start_paused = true in the new integration test since it performs real network I/O, which can cause virtual clock issues, and adjusting the elapsed time assertion to account for real-world timing variations.
Adds ClientBuilder::with_connect_timeout and with_read_timeout, applied to the HTTP transport. Bumps gax to 1.16.0 and gax-internal to 0.7.22. Fixes googleapis#7234
bfea5f8 to
87f5e3c
Compare
|
Thank you! |
…timeouts # Conflicts: # src/gax-internal/echo-server/src/lib.rs
|
Hi @joshuatants, happy Monday! Alex has addressed the review feedback, so this is ready for another look whenever you have a moment. Thanks! |
…timeouts # Conflicts: # Cargo.toml
|
Main now has unpublished updates to google-cloud-gax-internal and google-cloud-gax. If those get released before this is merged, we’ll need to update this PR to bump those versions. |
Adds ClientBuilder::with_connect_timeout and with_read_timeout, applied to the HTTP transport. Bumps gax to 1.16.0 and gax-internal to 0.7.22.
Fixes #7234