Skip to content

chore: update sources and regenerate - #6954

Closed
sofisl wants to merge 1 commit into
mainfrom
chore-update-libraries-2026-09-22
Closed

chore: update sources and regenerate#6954
sofisl wants to merge 1 commit into
mainfrom
chore-update-libraries-2026-09-22

Conversation

@sofisl

@sofisl sofisl commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update sources and regenerate.

Debug Info

System Details

  • Rust version: rustc 1.95.0 (59807616e 2026-04-14)
  • Cargo version: cargo 1.95.0 (f2d3ce0bd 2026-03-21)
  • OS: Linux 7.1.6-1rodete1-amd64 x86_64
  • Librarian version: v0.45.0

Commands Executed

  • go run github.com/googleapis/librarian/cmd/[email protected] update sources.googleapis sources.discovery
  • go run github.com/googleapis/librarian/cmd/[email protected] install
  • go run github.com/googleapis/librarian/cmd/[email protected] generate --all
  • git add .
  • git commit -m "chore: update sources and regenerate"

Included googleapis CLs

google/bigtable/admin/v2

google/cloud/agentregistry/v1

google/cloud/geminidataanalytics/v1

google/cloud/lustre/v1

google/cloud/parametermanager/v1

google/cloud/sql/v1

google/cloud/tasks/v2

google/cloud/vectorsearch/v1

google/monitoring/dashboard/v1

@sofisl
sofisl requested review from a team as code owners September 22, 2026 23:01
@gemini-code-assist

gemini-code-assist Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@dbolduc

dbolduc commented Sep 22, 2026

Copy link
Copy Markdown
Member 
   Checking google-cloud-compute-v1 v3.5.0 (/workspace/src/generated/cloud/compute/v1)
error[E0428]: the name `global_frontend_settings` is defined multiple times
      --> src/generated/cloud/compute/v1/src/model.rs:488919:1
       |
106002 | pub mod global_frontend_settings {
       | -------------------------------- previous definition of the module `global_frontend_settings` here
...
488919 | pub mod global_frontend_settings {
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `global_frontend_settings` redefined here
       |
       = note: `global_frontend_settings` must be defined only once in the type namespace of this module

Ugh looks like the new compute update uncovered a bug in the Rust generator.

@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.18%. Comparing base (26dc748) to head (c18c904).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6954   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files         325      325           
  Lines      111442   111442           
=======================================
+ Hits       108302   108305    +3     
+ Misses       3140     3137    -3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc

dbolduc commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

It seems like a problem in the sidekick model. We have a message and a service1 with the same ID.

@sofisl - Maybe just revert src/generated/cloud/compute/v1 and skip_generate: true for compute? This seems like a bug that will take effort to fix

I opened #6960. I am on duty and I won't have time to look at it tomorrow.

Footnotes

  1. discovery model maps resources to services. ↩

@dbolduc dbolduc mentioned this pull request Sep 23, 2026
Open
@sofisl sofisl closed this Sep 23, 2026
@sofisl sofisl mentioned this pull request Sep 23, 2026
Closed
@dbolduc
dbolduc deleted the chore-update-libraries-2026-09-22 branch November 9, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sofisl @dbolduc