Skip to content

feat(visionai-v1): generate library#5136

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-visionai-v1-generate-library
Mar 25, 2026
Merged

feat(visionai-v1): generate library#5136
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-visionai-v1-generate-library

Conversation

@coryan
Copy link
Copy Markdown
Collaborator

@coryan coryan commented Mar 25, 2026

Fixes #4987

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.89%. Comparing base (5c4749f) to head (8abdcda).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5136   +/-   ##
=======================================
  Coverage   97.88%   97.89%           
=======================================
  Files         211      211           
  Lines       42072    42072           
=======================================
+ Hits        41184    41185    +1     
+ Misses        888      887    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review March 25, 2026 13:30
@coryan coryan requested a review from a team as a code owner March 25, 2026 13:30

[package]
name = "google-cloud-visionai-v1"
version = "0.0.0"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intended?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... I think that is how the Librarian folks want things. The bump to 1.0 happens after the library is introduced.

@JoeWang1127 is there a playbook, link, document explaining why we start at 0.0.0 ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial version is 0.0.0 if not defined in library config: https://github.com/googleapis/librarian/blob/78db342a567abfa775bea2bda5ce31767fb794ff/internal/sidekick/rust/codec.go#L75

I think you can update this value to have a different initial version.

@coryan coryan merged commit 0015712 into googleapis:main Mar 25, 2026
36 checks passed
@coryan coryan deleted the feat-visionai-v1-generate-library branch March 25, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate library for google/cloud/visionai/v1/visionai_v1.yaml

3 participants