impl(gax-internal): set the client span error attributes#4937
Merged
coryan merged 1 commit intogoogleapis:mainfrom Mar 8, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4937 +/- ##
==========================================
- Coverage 94.08% 94.05% -0.03%
==========================================
Files 219 219
Lines 8521 8529 +8
==========================================
+ Hits 8017 8022 +5
- Misses 504 507 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
westarle
approved these changes
Mar 8, 2026
westarle
requested changes
Mar 8, 2026
Contributor
westarle
left a comment
westarle
left a comment
There was a problem hiding this comment.
oops one thing:
Generally, Instrumentation Libraries SHOULD NOT set the status code to Ok, unless explicitly configured to do so. Instrumentation Libraries SHOULD leave the status code as Unset unless there is an error, as described above.
westarle
reviewed
Mar 8, 2026
westarle
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the work for #4924 adds some missing fields to the client request spans.