fix: paginated response items#3431
Merged
coryan merged 5 commits intogoogleapis:mainfrom Sep 29, 2025
Merged
Conversation
This fixes a bug in the generated code for a few clients: in paginated responses we should use the first eligible field for the items.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3431 +/- ##
==========================================
+ Coverage 96.15% 96.18% +0.02%
==========================================
Files 116 116
Lines 4583 4583
==========================================
+ Hits 4407 4408 +1
+ Misses 176 175 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codyoss
previously approved these changes
Sep 29, 2025
dbolduc
reviewed
Sep 29, 2025
| #[doc(hidden)] | ||
| impl gax::paginator::internal::PageableResponse for InstancesListResponse { | ||
| type PageItem = crate::model::DatabaseInstance; | ||
| type PageItem = crate::model::ApiWarning; |
Member
There was a problem hiding this comment.
I don't think we should merge this as-is.
Collaborator
Author
There was a problem hiding this comment.
Agree, I implemented the override for SQL admin and regenerated the code, PTAL.
dbolduc
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the generated code for a few clients: in paginated
responses we should use the first eligible field for the items.
Fixes #3430