Skip to content

docs: Show actual enum values in setter samples.#3415

Merged
amanda-tarafa merged 1 commit intogoogleapis:mainfrom
amanda-tarafa:setter-samples
Oct 8, 2025
Merged

docs: Show actual enum values in setter samples.#3415
amanda-tarafa merged 1 commit intogoogleapis:mainfrom
amanda-tarafa:setter-samples

Conversation

@amanda-tarafa
Copy link
Copy Markdown
Collaborator

No description provided.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 25, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.86%. Comparing base (12c8dc9) to head (6394c2a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3415   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         120      120           
  Lines        4789     4789           
=======================================
  Hits         4591     4591           
  Misses        198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amanda-tarafa amanda-tarafa force-pushed the setter-samples branch 2 times, most recently from a9c1eb5 to 2dc633f Compare October 7, 2025 06:41
@amanda-tarafa amanda-tarafa changed the title temp: Show some enum values in samples docs: Show actual enum values in setter samples. Oct 7, 2025
@amanda-tarafa
Copy link
Copy Markdown
Collaborator Author

This is the result of googleapis/librarian#2491

Copy link
Copy Markdown
Collaborator

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I look forward to the release where all these examples are everywhere. I am more excited about the release with examples for all the RPCs!

@amanda-tarafa
Copy link
Copy Markdown
Collaborator Author

I look forward to the release where all these examples are everywhere. I am more excited about the release with examples for all the RPCs!

Just one-off setters coming up, and then the ones for RPCs :)

@amanda-tarafa amanda-tarafa marked this pull request as ready for review October 8, 2025 19:37
@amanda-tarafa amanda-tarafa requested a review from a team October 8, 2025 19:37
@amanda-tarafa amanda-tarafa merged commit a1afde2 into googleapis:main Oct 8, 2025
24 checks passed
@amanda-tarafa amanda-tarafa deleted the setter-samples branch October 8, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants