feat: Add package version constraints for all dependencies#3396
feat: Add package version constraints for all dependencies#3396coryan merged 5 commits intogoogleapis:mainfrom
Conversation
|
I suspect you will want to change this: To use the version found with: go list -m -u -f '{{.Version}}' github.com/googleapis/librarian@mainIt also looks like a |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 115 115
Lines 4573 4573
=======================================
Hits 4399 4399
Misses 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I don't care that the generated code is out-of-date, I just want the configuration to be correct for googleapis/librarian#2331
Done. |
devoncarew
left a comment
There was a problem hiding this comment.
Did you mean to include the LICENSE files as well?
| 'package:google_cloud_gax' = '^0.1.0' | ||
| 'package:http' = '^1.3.0' | ||
|
|
||
| # Generated packages |
There was a problem hiding this comment.
I assume these are the ones that are currently referenced by other (generated) packages.
There was a problem hiding this comment.
Yes. Maybe
| # Generated packages | |
| # Generated packages used as dependencies. |
?
There was a problem hiding this comment.
I'm fine w/ either, I was just confirming this for my own understanding.
For the CI to pass, I had to re-run the generator, which produced the LICENSE files. |
It did not occur to me earlier, but you could change the CI build to skip checking of the LICENSE files. The CI scripts are right here in this repo. |
Since the LICENSE files are generated, shouldn't they be checked just like everything else? Hopefully this will be the last time that we need to update this code before we have a separate repo for dart but isn't the idea that no checkins should be allowed where the generated code doesn't match that produced by the CI? |
|
/gcbrun |
Yes, you are right. Forget what I said. |
Fixes #1989 This should not be landed before googleapis/google-cloud-rust#3396
Librarian Version: v0.0.0-20250925031739-cb21cf1ae8af Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest <details><summary>librarian: 0.3.0</summary> ## [0.3.0](v0.2.0...v0.3.0) (2025-09-25) ### Features * discovery-based APIs and pagination (#2350) ([cb21cf1](cb21cf1)) * Make generated `ProtoMessage` and `ProtoEnum` classes `final` (#2349) ([7d0520b](7d0520b)) * Require that all imports have a version contraints (#2331) Fixes #1989 This should not be landed before googleapis/google-cloud-rust#3396 ([00828d5](00828d5)) * Generate samples for single value setters (#2263) ([f7c0b84](f7c0b84)) * discovery doc arrays (#2337) ([da69195](da69195)) * Inject InstrumentationClientInfo for tracing (#2252) - Add static INSTRUMENTATION_CLIENT_INFO to lib.rs.mustache. - Use INSTRUMENTATION_CLIENT_INFO in transport.rs.mustache if tracing is enabled. For #2212 see also googleapis/google-cloud-rust#3347 and googleapis/google-cloud-rust#3376 ([1358226](1358226)) * parse most object fields (#2318) Parse most fields of object in a discovery doc. Fields with an inline type definition still need some custom work. ([f2d1a10](f2d1a10)) * Add the ability to insert text after the package title (#2323) The current use case for this is to advise users of equivalent Firebase packages. For example: ```toml readme-after-title-text = """> [!TIP] > Flutter applications should use [Firebase AI Logic](https://firebase.google.com/products/firebase-ai-logic). > > The Generate Language API is meant for Dart desktop and cloud applications. > Firebase AI Logic provides client-side access to both the Gemini Developer > API and Vertex AI. """ ``` Which results in a README.md that looks like: <img width="1485" height="909" alt="image" src="https://github.com/user-attachments/assets/a1c9120e-eafd-4394-9562-48c595ab4960" /> ([756e72f](756e72f)) ### Bug Fixes * read version from version.txt file (#2347) Fixes #2348 Moves version.txt to the `internal/cli` package so it can be read by the `embed` package as a variable. When constructing the synthetic version number, use this release version as the base. ([014b5f4](014b5f4)) * race condition in createWorkRoot() (#2338) Creating a temporary directory based on a timestamp is inherently racy. Use the standard functions to create temporary directories, and relax the tests to check for what matters. ([46428ca](46428ca)) * parse github remote from local directory (#2328) Fixes #2327 ([1c71bd9](1c71bd9)) </details>
No description provided.