refactor(gax-internal): Update InstrumentationClientInfo handling#3376
Merged
westarle merged 1 commit intogoogleapis:mainfrom Sep 22, 2025
Merged
Conversation
Contributor
westarle
commented
Sep 22, 2025
- Store InstrumentationClientInfo as Option<&'static ...> in ReqwestClient.
- Pass as &'static ... to with_instrumentation.
- Accept as Option<&'static ...> in HttpSpanInfo::from_request
- mark non-exhaustive so we can add fields in the future as needed (default to "")
…- Store InstrumentationClientInfo as Option<&'static ...> in ReqwestClient. - Pass as &'static ... to with_instrumentation. - Accept as Option<&'static ...> in HttpSpanInfo::from_request.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3376 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 115 115
Lines 4573 4573
=======================================
Hits 4400 4400
Misses 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Sep 22, 2025
westarle
added a commit
to googleapis/librarian
that referenced
this pull request
Sep 24, 2025
- Add static INSTRUMENTATION_CLIENT_INFO to lib.rs.mustache. - Use INSTRUMENTATION_CLIENT_INFO in transport.rs.mustache if tracing is enabled. For #2212 see also googleapis/google-cloud-rust#3347 and googleapis/google-cloud-rust#3376
This was referenced Sep 24, 2025
ldetmer
pushed a commit
to googleapis/librarian
that referenced
this pull request
Sep 26, 2025
Librarian Version: v0.0.0-20250925031739-cb21cf1ae8af Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest <details><summary>librarian: 0.3.0</summary> ## [0.3.0](v0.2.0...v0.3.0) (2025-09-25) ### Features * discovery-based APIs and pagination (#2350) ([cb21cf1](cb21cf1)) * Make generated `ProtoMessage` and `ProtoEnum` classes `final` (#2349) ([7d0520b](7d0520b)) * Require that all imports have a version contraints (#2331) Fixes #1989 This should not be landed before googleapis/google-cloud-rust#3396 ([00828d5](00828d5)) * Generate samples for single value setters (#2263) ([f7c0b84](f7c0b84)) * discovery doc arrays (#2337) ([da69195](da69195)) * Inject InstrumentationClientInfo for tracing (#2252) - Add static INSTRUMENTATION_CLIENT_INFO to lib.rs.mustache. - Use INSTRUMENTATION_CLIENT_INFO in transport.rs.mustache if tracing is enabled. For #2212 see also googleapis/google-cloud-rust#3347 and googleapis/google-cloud-rust#3376 ([1358226](1358226)) * parse most object fields (#2318) Parse most fields of object in a discovery doc. Fields with an inline type definition still need some custom work. ([f2d1a10](f2d1a10)) * Add the ability to insert text after the package title (#2323) The current use case for this is to advise users of equivalent Firebase packages. For example: ```toml readme-after-title-text = """> [!TIP] > Flutter applications should use [Firebase AI Logic](https://firebase.google.com/products/firebase-ai-logic). > > The Generate Language API is meant for Dart desktop and cloud applications. > Firebase AI Logic provides client-side access to both the Gemini Developer > API and Vertex AI. """ ``` Which results in a README.md that looks like: <img width="1485" height="909" alt="image" src="https://github.com/user-attachments/assets/a1c9120e-eafd-4394-9562-48c595ab4960" /> ([756e72f](756e72f)) ### Bug Fixes * read version from version.txt file (#2347) Fixes #2348 Moves version.txt to the `internal/cli` package so it can be read by the `embed` package as a variable. When constructing the synthetic version number, use this release version as the base. ([014b5f4](014b5f4)) * race condition in createWorkRoot() (#2338) Creating a temporary directory based on a timestamp is inherently racy. Use the standard functions to create temporary directories, and relax the tests to check for what matters. ([46428ca](46428ca)) * parse github remote from local directory (#2328) Fixes #2327 ([1c71bd9](1c71bd9)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.