feat(generator/dart): generate and implement the struct.proto well known types#1820
Merged
devoncarew merged 3 commits intogoogleapis:mainfrom Apr 16, 2025
Merged
feat(generator/dart): generate and implement the struct.proto well known types#1820devoncarew merged 3 commits intogoogleapis:mainfrom
devoncarew merged 3 commits intogoogleapis:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1820 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 54 54
Lines 1998 1998
=======================================
Hits 1920 1920
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Apr 16, 2025
Co-authored-by: Carlos O'Ryan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
struct.protowell known typesFooHelperclassses library private (these are used to implement custom json encodings; they don't need to be visible outside the library)This allows generation of
google_cloud_firestore_v1- it usesStructandNullValue; we're able to make some calls with that library now.Generating NullValue meant we had to adjust the types for toJson() a bit - we hadn't expected
nullvalues to be produced.This should complete all the messages that have custom encodings.
The
Valueclass needed enough customization post-generation (mostly to deal with null values in and out) that I decided to generate and modify it rather than parameterize the mustache templates for a single use case. We're also doing this (using hand-written versions) forAnyandOperation. We could generate unmodified versions of these to markdown files, check those in, and use the diffs to be aware of any upstream changes. I understand changes to these types to be extremely rare, but it might be useful to know about doc changes and such.