feat(generator/dart): rewrite json encoding+decoding to capture edge cases#1807
Merged
devoncarew merged 3 commits intogoogleapis:mainfrom Apr 15, 2025
Merged
feat(generator/dart): rewrite json encoding+decoding to capture edge cases#1807devoncarew merged 3 commits intogoogleapis:mainfrom
devoncarew merged 3 commits intogoogleapis:mainfrom
Conversation
coryan
approved these changes
Apr 15, 2025
Comment on lines
+31
to
+34
| /// Decode a `double` value. | ||
| double? decodeDouble(Object? value) { | ||
| return (value as num?)?.toDouble(); | ||
| } |
Collaborator
There was a problem hiding this comment.
ProtoJSON uses strings to represent NaN, Infinity and -Infinity. Consider opening a bug to handle these cases.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1807 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 54 54
Lines 1998 1998
=======================================
Hits 1920 1920
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devoncarew
commented
Apr 15, 2025
Contributor
Author
devoncarew
left a comment
devoncarew
left a comment
There was a problem hiding this comment.
Thanks for the review! updated
Comment on lines
+31
to
+34
| /// Decode a `double` value. | ||
| double? decodeDouble(Object? value) { | ||
| return (value as num?)?.toDouble(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the JSON encoding+decoding to capture edge cases:
google_cloud_gax/lib/src/encoding.dart