feat(generator/dart): add error utility methods to rpc.Status#1702
Merged
devoncarew merged 1 commit intogoogleapis:mainfrom Apr 3, 2025
Merged
feat(generator/dart): add error utility methods to rpc.Status#1702devoncarew merged 1 commit intogoogleapis:mainfrom
devoncarew merged 1 commit intogoogleapis:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1702 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 48 48
Lines 1849 1849
=======================================
Hits 1779 1779
Misses 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Apr 3, 2025
| /// list. | ||
| /// | ||
| /// All error responses are expected to include an [ErrorInfo] object. | ||
| ErrorInfo? get errorInfo { |
Collaborator
There was a problem hiding this comment.
Good idea, I might copy that for Rust. @dbolduc FYI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error utility methods to
rpc.Status:Status.errorInfogetter which retrieves the single expected ErrorInfo instance from Status.detailsStatus.localizedMessagegetter to get anyLocalizedMessagefrom the details listStatus.detailsAsMessageswhich can autoconvert the ~10 known error typesAny- add custom support for unpackaging errors fromStatus.details#1572This should make it easier for users to unpack the
Anymessages fromStatus.details. Code completion will show the existing members forStatus(code, message, details) as well as these three new extension methods.