Skip to content

feat(generator/dart): generate google/iam/v1#1684

Merged
devoncarew merged 3 commits intogoogleapis:mainfrom
devoncarew:generate_iam
Apr 2, 2025
Merged

feat(generator/dart): generate google/iam/v1#1684
devoncarew merged 3 commits intogoogleapis:mainfrom
devoncarew:generate_iam

Conversation

@devoncarew
Copy link
Copy Markdown
Contributor

@devoncarew
Copy link
Copy Markdown
Contributor Author

And I should have mentioned - this is generated w/ the explicit name in the package (package:google_cloud_iam_v1, w/ entry-point lib/iam_v1.dart) because I see that the rust sdk generates all three versions of iam: https://github.com/googleapis/google-cloud-rust/tree/main/src/generated/iam, and I'm guessing we're going to need to do something similar.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (2b99ccc) to head (a5da8ed).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1684   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files          47       47           
  Lines        1850     1850           
=======================================
  Hits         1775     1775           
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan
Copy link
Copy Markdown
Collaborator

coryan commented Apr 1, 2025

And I should have mentioned - this is generated w/ the explicit name in the package (package:google_cloud_iam_v1, w/ entry-point lib/iam_v1.dart) because I see that the rust sdk generates all three versions of iam: https://github.com/googleapis/google-cloud-rust/tree/main/src/generated/iam, and I'm guessing we're going to need to do something similar.

Yes. For Rust (and other languages, but not all) we included the -v${N} in the package name. In anticipation of future versions of the service: if there are *-v1, *-v2 and *-v3 versions of a service we want to avoid creating a single package that has all of them. That is confusing and leads to big packages.

@devoncarew devoncarew merged commit eed00de into googleapis:main Apr 2, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generate google/iam

2 participants