feat(generator/dart): generate google.protobuf.Timestamp with custom encoding and decoding#1627
Conversation
…encoder and decoder
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1627 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 43 43
Lines 1825 1825
=======================================
Hits 1747 1747
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Maybe one more test case for you to consider. Which I do realize is missing from the Rust code too.
| }); | ||
| } | ||
|
|
||
| roundTrip('0001-01-01T00:00:00Z'); |
There was a problem hiding this comment.
It would be nice to have some time with negative seconds and non-zero nanos.
There was a problem hiding this comment.
and it turns out Rust had some bugs, see #1634
There was a problem hiding this comment.
Thanks - I added the tests from the updated Rust impl and addressed an issue w/ negative seconds and non-zero nanos.
2 participants
google.protobuf.Timestampwith custom encoding and decoding