Skip to content

Set per attempt_timeout on the client #4466

Closed

Description

@dbolduc

We expose .with_attempt_timeout only on our request builders. They cannot be set on the client builder.

Note that similar properties like the retry policy can be set once per client, and overridden per request. That can simplify some application code that calls multiple RPCs with the same policies.

To support this, we need to:

  • add a fn with_attempt_timeout(...) on the gax::client_builder::ClientBuilder.
  • store the value in the gax::internal::ClientConfig
  • plumb the value into our gax-internal::http::ReqwestClient and gax-internal::grpc::GrpcClients.
  • use the client default if one is not set per request in both the clients. (e.g. this logic for HTTP retry policy)
  • and add tests, obviously.

Activity

  1. added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    priority: p3Desirable enhancement or fix. May not be included in next release.
    on Jan 30, 2026
  2. abhinavgautam01 commented on May 8, 2026

    @abhinavgautam01
    Contributor

    Hi @dbolduc , I’d love to work on #4466...
    Can you assign this to me...

  3. dbolduc commented on May 8, 2026

    @dbolduc
    MemberAuthor

    Done! Let me know if you have questions

  4. added a commit that references this issue on May 11, 2026
    2ad561e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

priority: p3Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions