Skip to content

Add Video Intelligence v1beta2 GAPIC#1702

Merged
blowmage merged 7 commits intogoogleapis:masterfrom
geigerj:video-v1b2
Sep 1, 2017
Merged

Add Video Intelligence v1beta2 GAPIC#1702
blowmage merged 7 commits intogoogleapis:masterfrom
geigerj:video-v1b2

Conversation

@geigerj
Copy link
Copy Markdown
Contributor

@geigerj geigerj commented Aug 31, 2017

No description provided.

@geigerj geigerj requested a review from blowmage August 31, 2017 21:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2017
@geigerj
Copy link
Copy Markdown
Contributor Author

geigerj commented Aug 31, 2017

@blowmage After this is merged, could you create a point release?

@blowmage
Copy link
Copy Markdown
Contributor

blowmage commented Aug 31, 2017

@geigerj Do you want V1beta2 added to the documentation along side V1beta1?

@geigerj
Copy link
Copy Markdown
Contributor Author

geigerj commented Aug 31, 2017

Ah, right... I'll update the Rakefile.

@blowmage
Copy link
Copy Markdown
Contributor

blowmage commented Aug 31, 2017

We will need to update the dependency on google-gax to 0.8.5 in the gemspec since this new code depends on Google::Gax::Credentials.

@blowmage
Copy link
Copy Markdown
Contributor

blowmage commented Aug 31, 2017

After this is merged, could you create a point release?

I'm not sure what you mean by "point release". The current release is 0.21.0. I would tend towards releasing these changes as a new minor version, like 0.22.0. Can you confirm that this is not what you want, and would rather see this as a 0.21.1 patch release instead?

@blowmage
Copy link
Copy Markdown
Contributor

blowmage commented Aug 31, 2017

I can follow this PR up with another PR making the additional changes needed.

@geigerj
PR fixes
526e765 
- Add V1beta2 to Rakefile doc generation
- Copy new autogen gemspec
@geigerj
Copy link
Copy Markdown
Contributor Author

geigerj commented Aug 31, 2017

Updated Rakefile and gemspec.

Re: versions, please follow whatever convention you've been following. For GAX, we've used a minor release increment to indicate a breaking change when in major version 0, but it's fine to use it here if that's what you've been doing for large changes like a new API version.

blowmage
blowmage reviewed Aug 31, 2017
View reviewed changes
Comment thread google-cloud-video_intelligence/google-cloud-video_intelligence.gemspec

gem.add_dependency "google-gax", "~> 0.8.0"
gem.add_dependency "google-gax", "~> 0.8.6"
gem.add_dependency "googleapis-common-protos", "~> 1.3.1"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@blowmage
Update rubocop excludes
61d5b8f 
Ignore the main required file as it violates many rules.
@blowmage
Correct client_config YARD formatting
7c869e9
@blowmage
Overload YARD parameter docs
5cf0dad 
In order to docucment method arguments that aren't declared you must use
the @overload tag.
@blowmage
Add YARD dev dependencies
b4ab81d 
This will resolve the warning: Error loading plugin 'yard-doctest'
@blowmage
Add V1beta2 documentation config
9274f08
@googlebot
Copy link
Copy Markdown

googlebot commented Sep 1, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 1, 2017
@blowmage
Copy link
Copy Markdown
Contributor

blowmage commented Sep 1, 2017

I am the author of these commits.

@blowmage blowmage added api: videointelligence Issues related to the Video Intelligence API API. cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 1, 2017
@blowmage blowmage requested a review from quartzmo September 1, 2017 05:40
@blowmage
Copy link
Copy Markdown
Contributor

blowmage commented Sep 1, 2017

@quartzmo I had to massage the YARD formatting to get these changes to pass the CI build, as well as to add the new classes to the documentation output. Can you look them over and give some feedback? Is this the right approach?

@geigerj
Copy link
Copy Markdown
Contributor Author

geigerj commented Sep 1, 2017

@blowmage Thank you for the fixes. Once we're set on the right YARD formatting, I'll get fixes in to the generator.

@quartzmo
Copy link
Copy Markdown
Member

quartzmo commented Sep 1, 2017

@blowmage Your YARD fixes look good to me!

@geigerj geigerj mentioned this pull request Sep 1, 2017
Closed
@blowmage blowmage merged commit 564ed29 into googleapis:master Sep 1, 2017
geigerj added a commit to geigerj/toolkit that referenced this pull request Sep 8, 2017
@geigerj
Ruby documentation fixes
0b428b9 
Based on feedback from
  googleapis/google-cloud-ruby#1702
geigerj added a commit to geigerj/toolkit that referenced this pull request Sep 8, 2017
@geigerj
Ruby documentation fixes
ef8554f 
Based on feedback from
  googleapis/google-cloud-ruby#1702
geigerj added a commit to geigerj/toolkit that referenced this pull request Sep 8, 2017
@geigerj
Ruby documentation fixes
e465b10 
Based on feedback from
  googleapis/google-cloud-ruby#1702
geigerj added a commit to geigerj/toolkit that referenced this pull request Sep 8, 2017
@geigerj
Ruby documentation fixes
43fbadf 
Based on feedback from
  googleapis/google-cloud-ruby#1702

- Use "@overload" to prevent YARD from being confused when @param docs
  do not match the *args, **kwargs method signature
- Do not use *args, **kwargs when the true method signature is known
- End version index files in newline, per convention
@geigerj geigerj mentioned this pull request Sep 8, 2017
Merged
geigerj added a commit to googleapis/gapic-generator that referenced this pull request Sep 11, 2017
@geigerj
Ruby documentation fixes (#1549)
e2f915a 
Based on feedback from
  googleapis/google-cloud-ruby#1702

- Use "@overload" to prevent YARD from being confused when @param docs
  do not match the *args, **kwargs method signature
- Do not use *args, **kwargs when the true method signature is known
- End version index files in newline, per convention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quartzmo quartzmo Awaiting requested review from quartzmo

1 more reviewer

@blowmage blowmage blowmage left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: videointelligence Issues related to the Video Intelligence API API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@geigerj @blowmage @googlebot @quartzmo