Skip to content

Change LocalStack of batches from global to client-local in storage #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 3 commits into from
Jul 21, 2015
Merged

Change LocalStack of batches from global to client-local in storage #990

dhermes merged 3 commits into from
Jul 21, 2015

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 14, 2015

Has #989 as diffbase

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Jul 14, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2015
This was referenced Jul 14, 2015
Merged
Merged
@tseaver
Copy link
Contributor

tseaver commented Jul 20, 2015

@dhermes ping me after #989 lands (a rebase would help review).

@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2015

Will do

@dhermes dhermes mentioned this pull request Jul 20, 2015
Merged
@dhermes dhermes force-pushed the storage-move-stack-to-client branch from be75a35 to 8a64306 Compare July 20, 2015 21:23
@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2015

@tseaver Rebased

tseaver
tseaver reviewed Jul 20, 2015
View reviewed changes
gcloud/storage/blob.py Outdated

This comment was marked as spam.

Sign in to view

dhermes added 3 commits July 20, 2015 16:55
@dhermes
Update storage.Client to hold stack of batch objects.
cb6b7c5
@dhermes
Making connection a property on storage client.
e221edb 
This is to allow seamless switching between the stored
connection and the active batch.

Also undoing hack in storage system test since batches are
supported correctly now on clients.
@dhermes
Adding comment about using _connection in storage.blob.
7112533 
Doing this to address review commits. Also testing current()
in the presence of an empty batch stack.
@dhermes dhermes force-pushed the storage-move-stack-to-client branch from 8a64306 to 7112533 Compare July 21, 2015 00:05
@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2015

@tseaver I addressed 2 of the 3 comments and responded to the third (slightly changed a bit).

@tseaver
Copy link
Contributor

tseaver commented Jul 21, 2015

I can let the "real client" bit go, I guess. LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2015

Thanks!

dhermes added a commit that referenced this pull request Jul 21, 2015
@dhermes
Merge pull request #990 from dhermes/storage-move-stack-to-client
63af1e8 
Change LocalStack of batches from global to client-local in storage
@dhermes dhermes merged commit 63af1e8 into googleapis:master Jul 21, 2015
@dhermes dhermes deleted the storage-move-stack-to-client branch July 21, 2015 02:32
@dhermes dhermes mentioned this pull request Jul 21, 2015
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@renovate-bot
chore(deps): update dependency pypandoc to v1.6.4 (#990)
5368269
parthea pushed a commit that referenced this pull request Nov 24, 2025
@otorreno
fix: make logging handler close conditional to having the transport o…
54182c1 
…pened (#990)

There was a recent release (3.12.0) that included the changes introduced in
#917. The newly introduced close method seems to be called by AppEngine
Python runtime at shutdown, so if you would call it explicitly before the runtime
does it, then the close function throws an exception because transport is None.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: update templated files (#990)
d595c62 
Source-Link: googleapis/synthtool@a37f74c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:d3de8a02819f65001effcbd3ea76ce97e9bcff035c7a89457f40f892c87c5b32

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
@otorreno
fix: make logging handler close conditional to having the transport o…
91962c1 
…pened (#990)

There was a recent release (3.12.0) that included the changes introduced in
#917. The newly introduced close method seems to be called by AppEngine
Python runtime at shutdown, so if you would call it explicitly before the runtime
does it, then the close function throws an exception because transport is None.
parthea pushed a commit that referenced this pull request Nov 26, 2025
@gcf-owl-bot @arithmetic1728
feat: Pluggable auth support (#995)
97bde16 
* feat: Add Pluggable auth support (#988)

* Port identity pool credentials

* access_token retrieved

* -> pluggable

* Update pluggable.py

* Create test_pluggable.py

* Unit tests

* Address pr issues

* feat: Add file caching (#990)

* Add file cache

* feat: add output file cache support

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update pluggable.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update pluggable.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update setup.py

* Update setup.py

* Update setup.py

* pytest_subprocess

* timeout

* Update pluggable.py

* env

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update _default.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update requirements.txt

* Update _default.py

* Update pluggable.py

* Update pluggable.py

* Update pluggable.py

* Update test_pluggable.py

* format validations

* Update _default.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update requirements.txt

* Revert "Update requirements.txt"

This reverts commit 1c9b6db25c683663ed4b71ab0ab39946fce8f6eb.

* Revert "Update _default.py"

This reverts commit ac6c36072084a440c234a9465b35462bd52378b3.

* Revert "Revert "Update _default.py""

This reverts commit 1c08483586007e4caf1a36f2c9cbf2a45d403ee0.

* Raise output format error but retry parsing token if `success` is 0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update requirements.txt

* Delete test_pluggable.py

* Revert "Delete test_pluggable.py"

This reverts commit 74beba9405564a5b764af8718c49e640d9b84c5f.

* Update pluggable.py

* Update pluggable.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* pytest-subprocess

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* lint

* Update pluggable.py

* nox cover

nox cover

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* lint

* Update test_pluggable.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update test_pluggable.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: arithmetic1728 <[email protected]>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@gcf-owl-bot @arithmetic1728 @lsirac
feat: pluggable auth support (#1045)
4c8a5f9 
* feat: Add Pluggable auth support

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

feat: Add Pluggable auth support (#988)

* Port identity pool credentials

* access_token retrieved

* -> pluggable

* Update pluggable.py

* Create test_pluggable.py

* Unit tests

* Address pr issues

feat: Add file caching (#990)

* Add file cache

* feat: add output file cache support

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update pluggable.py

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update pluggable.py

Update setup.py

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update setup.py

Update setup.py

pytest_subprocess

timeout

Update pluggable.py

env

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update _default.py

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update requirements.txt

Update _default.py

Update pluggable.py

Update pluggable.py

Update pluggable.py

Update test_pluggable.py

format validations

Update _default.py

Update requirements.txt

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Revert "Update requirements.txt"

This reverts commit 1c9b6db25c683663ed4b71ab0ab39946fce8f6eb.

Revert "Update _default.py"

This reverts commit ac6c36072084a440c234a9465b35462bd52378b3.

Revert "Revert "Update _default.py""

This reverts commit 1c08483586007e4caf1a36f2c9cbf2a45d403ee0.

Raise output format error but retry parsing token if `success` is 0

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update requirements.txt

Delete test_pluggable.py

Revert "Delete test_pluggable.py"

This reverts commit 74beba9405564a5b764af8718c49e640d9b84c5f.

Update pluggable.py

Update pluggable.py

pytest-subprocess

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

lint

Update pluggable.py

nox cover

nox cover

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

lint

Update test_pluggable.py

Update test_pluggable.py

* Disable Pluggable Auth for Python 2.*

Update noxfile.py

* Update pluggable.py

* Update pluggable.py

* Update pluggable.py

* Update pluggable.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Address PR issues

* Update pluggable.py

* Update pluggable.py

* Update user-guide.rst

* Update user-guide.rst

* Update user-guide.rst

* Update user-guide.rst

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: arithmetic1728 <[email protected]>
Co-authored-by: Leo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes @tseaver @googlebot