Skip to content

fix(logging): fix proto copy#9420

Merged
busunkim96 merged 3 commits intogoogleapis:masterfrom
busunkim96:logging-docs-fix
Oct 10, 2019
Merged

fix(logging): fix proto copy#9420
busunkim96 merged 3 commits intogoogleapis:masterfrom
busunkim96:logging-docs-fix

Conversation

@busunkim96
Copy link
Copy Markdown
Contributor

@busunkim96 busunkim96 commented Oct 7, 2019 •
edited
Loading

Logging's synth.py wasn't moving the protos over to the right place. It looks like the 'correct' set were getting copied into a deeper directory.

This PR also adds toctrees so the v1 and v2 docs are split.

See the generated docs here.

There's a new type google.cloud.logging_v2.types.BigQueryOptions that the Logging team was asking for. Do I need to modify the v1 client to make it available there?

@busunkim96 busunkim96 added the api: logging Issues related to the Cloud Logging API. label Oct 7, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2019
@busunkim96 busunkim96 requested review from crwilcox and tseaver and removed request for crwilcox October 7, 2019 21:29
tseaver
tseaver suggested changes Oct 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't note these issues inline:

  • Shouldn't the logging/google/cloud/logging_v2/proto/cloud/logging_v2/proto/ directory be removed altogether?
  • Why does the PR delete logging/google/cloud/logging_v2/proto/log_entry.proto / logging/google/cloud/logging_v2/proto/log_severity.proto / logging/google/cloud/logging_v2/proto/logging.proto logging/google/cloud/logging_v2/proto/logging_config.proto / logging/google/cloud/logging_v2/proto/logging_metrics.proto? That is where they are supposed to be, I think, and we are retaining the equivalent _pb2.py files.

@busunkim96
Copy link
Copy Markdown
Contributor Author

busunkim96 commented Oct 8, 2019

Thank you for the review!

Shouldn't the logging/google/cloud/logging_v2/proto/cloud/logging_v2/proto/ directory be removed altogether?

It's gone as far as I can tell.

Why does the PR delete logging/google/cloud/logging_v2/proto/log_entry.proto / logging/google/cloud/logging_v2/proto/log_severity.proto / logging/google/cloud/logging_v2/proto/logging.proto logging/google/cloud/logging_v2/proto/logging_config.proto / logging/google/cloud/logging_v2/proto/logging_metrics.proto? That is where they are supposed to be, I think, and we are retaining the equivalent _pb2.py files.

Re-added.

@busunkim96 busunkim96 requested a review from tseaver October 8, 2019 23:38
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Oct 9, 2019 •
edited
Loading

@busunkim96

Shouldn't the logging/google/cloud/logging_v2/proto/cloud/logging_v2/proto/ directory be removed altogether?

It's gone as far as I can tell.

It still contains all the _pb2.py files, as well as __init__py. Oops, that is the directory which is supposed to contain those files.

@tseaver tseaver mentioned this pull request Oct 9, 2019
Merged
@busunkim96 busunkim96 merged commit 1ea60a4 into googleapis:master Oct 10, 2019
@busunkim96 busunkim96 deleted the logging-docs-fix branch October 10, 2019 18:07
parthea pushed a commit that referenced this pull request Nov 24, 2025
@busunkim96
fix(logging): fix proto copy (#9420)
aa78b3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@busunkim96 @tseaver @googlebot