Skip to content

Storage: HMAC add user_project param#9237

Merged
tseaver merged 3 commits intomasterfrom
hmac-user-project
Sep 25, 2019
Merged

Storage: HMAC add user_project param#9237
tseaver merged 3 commits intomasterfrom
hmac-user-project

Conversation

@jkwlui
Copy link
Copy Markdown
Contributor

@jkwlui jkwlui commented Sep 17, 2019

fixes #9236

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2019
Copy link
Copy Markdown
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@frankyn
Copy link
Copy Markdown
Contributor

frankyn commented Sep 25, 2019

@tseaver could you review and approve if LGTY? (I don't have permission to merge PRs).

@tseaver tseaver merged commit d8ce06e into master Sep 25, 2019
@tseaver tseaver deleted the hmac-user-project branch September 25, 2019 19:17
@jkwlui
Copy link
Copy Markdown
Contributor Author

jkwlui commented Sep 25, 2019

@tseaver Can you help cut a release so we get this fix out? Thanks!

@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Sep 26, 2019

@jkwlui release PR pending: #9319

parthea pushed a commit that referenced this pull request Mar 9, 2026
* test(unit): tests user_project is passed through to request

* feat: implement user_project option for HMAC operations

* fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage: hmac operations should support userProject

4 participants