Skip to content

Adding ability to sign URL from GAE. #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Jun 24, 2015
Merged

Adding ability to sign URL from GAE. #921

dhermes merged 1 commit into from
Jun 24, 2015

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jun 13, 2015

Also refactoring _get_signed_query_params and the related tests so that the signing process and service account name determination are isolated methods.

Fixes #607.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Jun 13, 2015

@jgeewax I was actually reminded of this old bug when discussing some performance issues of apitools on GCE.

Is there a GCE equivalent (I assume via metadata server) of

from google.appengine.api import app_identity
_, signed_bytes = app_identity.sign_blob(string_to_sign)

Is there someone who works on GCE who might be worth asking?

@jgeewax
Copy link
Contributor

jgeewax commented Jun 16, 2015

@ludoch : Do you know if there's a GCE equivalent of GAE Python's app_identity.sign_blob() ?

@dhermes dhermes mentioned this pull request Jun 16, 2015
Closed
@dhermes
Copy link
Contributor Author

dhermes commented Jun 16, 2015

@jgeewax I made #922 and commented on what the metadata server tells us about the service account.

@dhermes
Copy link
Contributor Author

dhermes commented Jun 24, 2015

@tseaver PTAL

tseaver
tseaver reviewed Jun 24, 2015
View reviewed changes
gcloud/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Adding ability to sign URL from GAE.
28bb674 
Also refactoring _get_signed_query_params and the related
tests so that the signing process and service account name
determination are isolated methods.

Fixes googleapis#607.
@dhermes
Copy link
Contributor Author

dhermes commented Jun 24, 2015

@tseaver Done (and rebased on top of HEAD).

@tseaver
Copy link
Contributor

tseaver commented Jun 24, 2015

LGTM

dhermes added a commit that referenced this pull request Jun 24, 2015
@dhermes
Merge pull request #921 from dhermes/fix-607
b975d9c 
Adding ability to sign URL from GAE.
@dhermes dhermes merged commit b975d9c into googleapis:master Jun 24, 2015
@dhermes dhermes deleted the fix-607 branch June 24, 2015 21:18
@dhermes dhermes mentioned this pull request Jul 10, 2015
Merged
parthea pushed a commit that referenced this pull request Aug 21, 2025
@gcf-owl-bot
chore(python): fix incorrect import statement in README (#921)
dcb152f 
Source-Link: googleapis/synthtool@8767740
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:023a21377a2a00008057f99f0118edadc30a19d1636a3fee47189ebec2f3921c

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@gcf-owl-bot @parthea
chore(python): fix incorrect import statement in README (#921)
3ccf7b6 
Source-Link: googleapis/synthtool@8767740
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:023a21377a2a00008057f99f0118edadc30a19d1636a3fee47189ebec2f3921c

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
@renovate-bot
chore(deps): update all dependencies (#921)
d72ea4c
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: update docfx minimum Python version (#921)
64c62f9 
Source-Link: googleapis/synthtool@bc07fd4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:30470597773378105e239b59fce8eb27cc97375580d592699206d17d117143d0

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: [autoapprove] bump cryptography from 41.0.3 to 41.0.4 (#921)
9512f78 
Source-Link: googleapis/synthtool@dede53f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fac304457974bb530cc5396abd4ab25d26a469cd3bc97cbfb18c8d4324c584eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@tseaver
docs: fix intersphinx link for 'requests-oauthlib' (#921)
19b5b73 
Closes #920.
parthea pushed a commit that referenced this pull request Nov 26, 2025
@release-please
chore(main): release 2.4.0 (#949)
3209283 
🤖 I have created a release *beep* *boop*
---


## [2.4.0](googleapis/google-auth-library-python@v2.3.3...v2.4.0) (2022-01-20)


### Features

* add 'py.typed' declaration ([#919](googleapis/google-auth-library-python#919)) ([c993504](googleapis/google-auth-library-python@c993504))
* add api key support ([#826](googleapis/google-auth-library-python#826)) ([3b15092](googleapis/google-auth-library-python@3b15092))


### Bug Fixes

* **deps:** allow cachetools 5.0 for python 3.7+ ([#937](googleapis/google-auth-library-python#937)) ([1eae37d](googleapis/google-auth-library-python@1eae37d))
* fix the message format for metadata server exception ([#916](googleapis/google-auth-library-python#916)) ([e756f08](googleapis/google-auth-library-python@e756f08))


### Documentation

* fix intersphinx link for 'requests-oauthlib' ([#921](googleapis/google-auth-library-python#921)) ([967be4f](googleapis/google-auth-library-python@967be4f))
* note ValueError in `verify_oauth2_token` ([#928](googleapis/google-auth-library-python#928)) ([82bc5f0](googleapis/google-auth-library-python@82bc5f0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @jgeewax @tseaver @googlebot