AutoML Tables: Skip relevant system tests if in VPCSC#9111
Merged
busunkim96 merged 3 commits intogoogleapis:masterfrom Aug 27, 2019
Merged
AutoML Tables: Skip relevant system tests if in VPCSC#9111busunkim96 merged 3 commits intogoogleapis:masterfrom
busunkim96 merged 3 commits intogoogleapis:masterfrom
Conversation
Unfortunately a large number of tests need to be skipped, since they depend on model/dataset creation, which only works when we have access to a bucket in the project under test. Since we are using a publicly readable bucket, this does not work.
googlebot
added
the
cla: yes
busunkim96
suggested changes
Aug 27, 2019
busunkim96
approved these changes
Aug 27, 2019
busunkim96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
|
@lwander It looks like you need an import: Is this the last set of changes you'll be making to the AutoML client for the upcoming release? |
Contributor
Author
|
@busunkim96 good catch. Almost, @TrucHLe & @jonathan1920 have changes they need to submit |
lwander
force-pushed
the
vpc-sc-ready
branch
2 times, most recently
from
462232a to
fbef97d
Compare
busunkim96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
HemangChothani
pushed a commit
to HemangChothani/google-cloud-python
that referenced
this pull request
Aug 29, 2019
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately a large number of tests need to be skipped, since they
depend on model/dataset creation, which only works when we have access
to a bucket in the project under test. Since we are using a publicly
readable bucket, this does not work.