Skip to content

AutoML Tables: Log when LROs are kicked off.#9058

Merged
busunkim96 merged 3 commits intogoogleapis:masterfrom
lwander:log-op
Aug 27, 2019
Merged

AutoML Tables: Log when LROs are kicked off.#9058
busunkim96 merged 3 commits intogoogleapis:masterfrom
lwander:log-op

Conversation

@lwander
Copy link
Copy Markdown
Contributor

@lwander lwander commented Aug 19, 2019

We have gotten feedback from users that the behavior of LROs is not
clear when python/juptyer sessions are cancelled. This is exacerbated by
Tables having some long (multi-hour) LROs. The message logged here is to
help clear this up.

See an example here:

Operation 'Model creation' is running in the background. The returned Operation 'projects/1234/locations/us-central1/operations/TBL1234' can be used to query or block on the status of this operation. Ending your python session will _not_ cancel this operation. Read the documentation here:

        https://googleapis.dev/python/google-api-core/latest/operation.html

for more information on the Operation class.

We have gotten feedback from users that the behavior of LROs is not
clear when python/juptyer sessions are cancelled. This is exacerbated by
Tables having some long (multi-hour) LROs. The message logged here is to
help clear this up.

See an example here:

```
Operation 'Model creation' is running in the background. The returned Operation 'projects/377154593326/locations/us-central1/operations/TBL2075574488031821824' can be used to query or block on the status of this operation. Ending your python session with _not_ cancel this operation. Read the documentation here:

        https://google-cloud-python.readthedocs.io/en/stable/core/operation.html

for more information on the Operation class.
```
@lwander lwander requested a review from busunkim96 as a code owner August 19, 2019 14:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2019
Comment thread automl/google/cloud/automl_v1beta1/tables/tables_client.py Outdated
Comment thread automl/google/cloud/automl_v1beta1/tables/tables_client.py Outdated
@busunkim96 busunkim96 requested a review from sirtorry August 19, 2019 16:44
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
Comment thread automl/google/cloud/automl_v1beta1/tables/tables_client.py Outdated
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@busunkim96 busunkim96 added the api: automl Issues related to the AutoML API. label Aug 19, 2019
@busunkim96
Copy link
Copy Markdown
Contributor

@sirtorry @lwander Please merge when you're ready.

Copy link
Copy Markdown
Contributor

@sirtorry sirtorry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but this isn't an AutoML tables or an AutoML specific problem. i'm wondering if we should surface to LROs in general @beccasaurus

@busunkim96 busunkim96 merged commit 2d29f3e into googleapis:master Aug 27, 2019
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
* AutoML Tables: Log when LROs are kicked off.

We have gotten feedback from users that the behavior of LROs is not
clear when python/juptyer sessions are cancelled. This is exacerbated by
Tables having some long (multi-hour) LROs. The message logged here is to
help clear this up.

See an example here:

```
Operation 'Model creation' is running in the background. The returned Operation 'projects/377154593326/locations/us-central1/operations/TBL2075574488031821824' can be used to query or block on the status of this operation. Ending your python session with _not_ cancel this operation. Read the documentation here:

        https://google-cloud-python.readthedocs.io/en/stable/core/operation.html

for more information on the Operation class.
```
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
* AutoML Tables: Log when LROs are kicked off.

We have gotten feedback from users that the behavior of LROs is not
clear when python/juptyer sessions are cancelled. This is exacerbated by
Tables having some long (multi-hour) LROs. The message logged here is to
help clear this up.

See an example here:

```
Operation 'Model creation' is running in the background. The returned Operation 'projects/377154593326/locations/us-central1/operations/TBL2075574488031821824' can be used to query or block on the status of this operation. Ending your python session with _not_ cancel this operation. Read the documentation here:

        https://google-cloud-python.readthedocs.io/en/stable/core/operation.html

for more information on the Operation class.
```
parthea pushed a commit that referenced this pull request Oct 21, 2023
* AutoML Tables: Log when LROs are kicked off.

We have gotten feedback from users that the behavior of LROs is not
clear when python/juptyer sessions are cancelled. This is exacerbated by
Tables having some long (multi-hour) LROs. The message logged here is to
help clear this up.

See an example here:

```
Operation 'Model creation' is running in the background. The returned Operation 'projects/377154593326/locations/us-central1/operations/TBL2075574488031821824' can be used to query or block on the status of this operation. Ending your python session with _not_ cancel this operation. Read the documentation here:

        https://google-cloud-python.readthedocs.io/en/stable/core/operation.html

for more information on the Operation class.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: automl Issues related to the AutoML API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants