Skip to content

Storage: Add 'Bucket.location_type' property.#8570

Merged
tseaver merged 2 commits intomasterfrom
storage-location_type-feature
Jul 12, 2019
Merged

Storage: Add 'Bucket.location_type' property.#8570
tseaver merged 2 commits intomasterfrom
storage-location_type-feature

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Jul 2, 2019

  • Add named constants for allowed 'storage_class' values.
  • Un-deprecate STANDARD storage class.
  • Docs-deprecate storage classes implying location type.
  • Add 'Bucket.location_type' property.
  • Add named constants for allowed 'location_type' values.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label Jul 2, 2019
@tseaver tseaver requested review from JesseLovelace and frankyn July 2, 2019 19:05
@tseaver tseaver requested a review from crwilcox as a code owner July 2, 2019 19:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2019
@tseaver tseaver force-pushed the storage-location_type-feature branch from 97b9cd2 to c43b7e7 Compare July 2, 2019 19:16
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Jul 2, 2019

Storage Kokoro job fails due to flaky systest, #8552.

@JesseLovelace JesseLovelace added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 2, 2019
@JesseLovelace
Copy link
Copy Markdown
Contributor

Thank you! Please hold off on merging until notified. Current prod rollout is planned for July 8

- Add named constants for allowed 'storage_class' values.
- Un-deprecate STANDARD storage class.
- Docs-deprecate storage classes implying location type.
- Add 'Bucket.location_type' property.
- Add named constants for allowed 'location_type' values.
@tseaver tseaver force-pushed the storage-location_type-feature branch from c43b7e7 to 9a618af Compare July 9, 2019 15:58
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Jul 9, 2019

Force-pushed to pick up the systest fix from #8617.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Jul 9, 2019

@crwilcox, @busunkim96 Can you look into why the CLA bot is not reporting status here?

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Jul 9, 2019

@JesseLovelace Please ping the PR when the back-end rollout is complete.

Comment thread storage/google/cloud/storage/bucket.py Outdated
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@JesseLovelace
Copy link
Copy Markdown
Contributor

Thanks!

Backend rollout is complete, this can be merged and released

@tseaver tseaver merged commit 36c2f30 into master Jul 12, 2019
@tseaver tseaver deleted the storage-location_type-feature branch July 12, 2019 16:46
parthea pushed a commit that referenced this pull request Mar 9, 2026
- Add named constants for allowed 'storage_class' values.
- Un-deprecate STANDARD storage class.
- Docs-deprecate storage classes implying location type.
- Add read-only 'Bucket.location_type' property.
- Add named constants for expected 'location_type' values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants