Storage: fix Client download_blob_to_file fails#8440
Merged
tseaver merged 4 commits intogoogleapis:masterfrom Jun 26, 2019
Merged
Storage: fix Client download_blob_to_file fails#8440tseaver merged 4 commits intogoogleapis:masterfrom
tseaver merged 4 commits intogoogleapis:masterfrom
Conversation
HemangChothani
requested review from
crwilcox,
frankyn and
tseaver
as code owners
googlebot
added
the
cla: yes
tseaver
added
api: storage
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
|
@HemangChothani Please check that unit tests pass with your change: if they do, then we are missing an assertion that the path is passed as expected. Also, please add a system test which exercises this feature (and ensure it passes with your change). |
tseaver
added
kokoro:force-run
tseaver
reviewed
Jun 24, 2019
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
suggested changes
Jun 25, 2019
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
Contributor
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8301