Skip to content

Storage: Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods.#8045

Merged
tseaver merged 5 commits intogoogleapis:storage-add-hmac-key-support-featurefrom
tseaver:7851-storage-hmac_key_metadata-exists-reload
Jun 19, 2019
Merged

Storage: Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods.#8045
tseaver merged 5 commits intogoogleapis:storage-add-hmac-key-support-featurefrom
tseaver:7851-storage-hmac_key_metadata-exists-reload

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented May 20, 2019

Uses #8041 as a base.

Toward #7851.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 20, 2019
@tseaver tseaver requested a review from jkwlui May 20, 2019 21:07
@tseaver tseaver requested a review from crwilcox as a code owner May 20, 2019 21:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@tseaver tseaver changed the title Storage: Add 'HMACKeyMetadata.{exists,reload}' methods. Storage: Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods. May 20, 2019
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 21, 2019

Rebased after merge of #8041 to the feature branch.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 23, 2019

@jkwlui This PR is ready for review.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 29, 2019

@jkwlui PTAL here, too.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 4, 2019
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Jun 5, 2019

@jkwlui The reCAPTCHA Enterprise failure is unrelated. PTAL.

@tseaver tseaver merged commit 970067b into googleapis:storage-add-hmac-key-support-feature Jun 19, 2019
@tseaver tseaver deleted the 7851-storage-hmac_key_metadata-exists-reload branch June 19, 2019 16:21
@tseaver tseaver mentioned this pull request Jun 19, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants