Skip to content

Storage: add 'Client.list_hmac_keys' method.#8043

Merged
tseaver merged 3 commits intogoogleapis:storage-add-hmac-key-support-featurefrom
tseaver:7851-storage-add-client-list_hmac_keys
May 29, 2019
Merged

Storage: add 'Client.list_hmac_keys' method.#8043
tseaver merged 3 commits intogoogleapis:storage-add-hmac-key-support-featurefrom
tseaver:7851-storage-add-client-list_hmac_keys

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented May 20, 2019

Incorporates commits from #8042.

Toward #7851.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 20, 2019
@tseaver tseaver requested a review from jkwlui May 20, 2019 20:17
@tseaver tseaver requested a review from crwilcox as a code owner May 20, 2019 20:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 20, 2019

Unrelated dataproc and scheduler failures due to Kokoro-internal glitch.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 21, 2019

Rebased after merge of #8041 to the feature branch.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2019
Copy link
Copy Markdown
Contributor

@jkwlui jkwlui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surface looks good!

@tseaver tseaver merged commit 66accf6 into googleapis:storage-add-hmac-key-support-feature May 29, 2019
@tseaver tseaver deleted the 7851-storage-add-client-list_hmac_keys branch May 29, 2019 15:49
@tseaver tseaver mentioned this pull request Jun 19, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants