Skip to content

Storage: add 'Client.create_hmac_key' method.#8042

Closed
tseaver wants to merge 2 commits intogoogleapis:storage-add-hmac-key-support-featurefrom
tseaver:7851-storage-add-client-create_hmac_key
Closed

Storage: add 'Client.create_hmac_key' method.#8042
tseaver wants to merge 2 commits intogoogleapis:storage-add-hmac-key-support-featurefrom
tseaver:7851-storage-add-client-create_hmac_key

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented May 20, 2019 •
edited
Loading

Uses #8041 as a base.

Toward #7851.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 20, 2019
@tseaver tseaver requested a review from jkwlui May 20, 2019 19:25
@tseaver tseaver requested a review from crwilcox as a code owner May 20, 2019 19:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@jkwlui jkwlui mentioned this pull request May 20, 2019
Closed
8 tasks
@tseaver tseaver mentioned this pull request May 20, 2019
Merged
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 20, 2019

Unrelated spanner failure due to Kokoro-internal glitch.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 21, 2019

Rebased after merge of #8041 to the feature branch.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 23, 2019

@jkwlui This PR is ready for review. If you'd rather work on a larger chunk, #8043 is based on this one: you could close this one and review there.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2019
@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented May 28, 2019

Thank you @tseaver, I'll review #8043 as a whole.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 28, 2019

Per @jkwlui, closing in favor of follow-on #8043, which contains these commits.

@tseaver tseaver closed this May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkwlui jkwlui Awaiting requested review from jkwlui

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @jkwlui @googlebot @yoshi-kokoro