Skip to content

Storage: add 'google.cloud.storage.hmac_keys.HMACKeyMetadata' resource class.#8041

Merged
tseaver merged 2 commits intogoogleapis:storage-add-hmac-key-support-featurefrom
tseaver:7851-storage-add-hmac_key_metadata
May 21, 2019
Merged

Storage: add 'google.cloud.storage.hmac_keys.HMACKeyMetadata' resource class.#8041
tseaver merged 2 commits intogoogleapis:storage-add-hmac-key-support-featurefrom
tseaver:7851-storage-add-hmac_key_metadata

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented May 20, 2019

@jkwlui Note that this PR targets the storage-add-hmac-key-support-feature branch, which will be merged to master once all the steps in #7851 are completed.

Toward #7851.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 20, 2019
@tseaver tseaver requested a review from jkwlui May 20, 2019 18:54
@tseaver tseaver requested a review from crwilcox as a code owner May 20, 2019 18:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 20, 2019

Unrelated system test flake. I reopened #7384.

Copy link
Copy Markdown
Contributor

@jkwlui jkwlui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved w/ nits

Comment thread storage/google/cloud/storage/hmac_key.py
Comment thread storage/google/cloud/storage/hmac_key.py
@tseaver tseaver merged commit 6fbf584 into googleapis:storage-add-hmac-key-support-feature May 21, 2019
@tseaver tseaver deleted the 7851-storage-add-hmac_key_metadata branch May 21, 2019 15:17
tseaver added a commit that referenced this pull request Jun 19, 2019
@tseaver tseaver mentioned this pull request Jun 19, 2019
1 task
tseaver added a commit that referenced this pull request Jun 26, 2019
tseaver added a commit that referenced this pull request Jul 2, 2019
tseaver added a commit that referenced this pull request Jul 2, 2019
tseaver added a commit that referenced this pull request Jul 9, 2019
tseaver added a commit that referenced this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants