Skip to content

Fix regression3 failures in pubsub #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 1 commit into from
Apr 7, 2015
Merged

Fix regression3 failures in pubsub #804

tseaver merged 1 commit into from
Apr 7, 2015

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 7, 2015

  • Message payload must be bytes, base64ed, but then must be serializable to JSON.
  • Likewise, 'attributes' values must be serializable to JSON.

@tseaver
Fix regression3 failures:
9fade02 
- Message payload must be bytes, base64ed, but then must be serializable to JSON.

- Likewise, 'attributes' values must be serializable to JSON.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2015
@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Apr 7, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Apr 7, 2015

See regression3 output on latest HEAD failure:

https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/57429797

@coveralls
Copy link

coveralls commented Apr 7, 2015

Coverage Status

Changes Unknown when pulling 9fade02 on tseaver:pubsub-fix_regression-py3k_bytes_attr into * on GoogleCloudPlatform:master*.

@dhermes
Copy link
Contributor

dhermes commented Apr 7, 2015

@tseaver Note this failure also showed up on the build linked to in #803.

@tseaver
Copy link
Contributor Author

tseaver commented Apr 7, 2015

Yup -- I just didn't look down far enough to see it. Should I merge?

@dhermes
Copy link
Contributor

dhermes commented Apr 7, 2015

Was still mid-review. LGTM.

tseaver added a commit that referenced this pull request Apr 7, 2015
@tseaver
Merge pull request #804 from tseaver/pubsub-fix_regression-py3k_bytes…
96ee9d3 
…_attr

Fix regression3 failures in pubsub
@tseaver tseaver merged commit 96ee9d3 into googleapis:master Apr 7, 2015
@tseaver tseaver deleted the pubsub-fix_regression-py3k_bytes_attr branch April 7, 2015 17:29
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@renovate-bot
chore(deps): update dependency protobuf to v3.15.5 (#804)
294ad65 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [protobuf](https://developers.google.com/protocol-buffers/) | `==3.15.4` -> `==3.15.5` | [![age](https://badges.renovateapi.com/packages/pypi/protobuf/3.15.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/protobuf/3.15.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/protobuf/3.15.5/compatibility-slim/3.15.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/protobuf/3.15.5/confidence-slim/3.15.4)](https://docs.renovatebot.com/merge-confidence/) |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-python).
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea
fix(deps): allow protobuf 6.x (#804)
40e89e1
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gkevinzheng @gcf-owl-bot
fix: Fixed object paths in autogenerated code in owlbot.py (#804)
b891fd6 
* fix: Fixed object paths in autogenerated code in owlbot.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
@gkevinzheng @gcf-owl-bot
fix: Fixed object paths in autogenerated code in owlbot.py (#804)
1ca6ee4 
* fix: Fixed object paths in autogenerated code in owlbot.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @coveralls @dhermes @googlebot