Skip to content

#744: Add 'pubsub.message.Message' class #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 2 commits into from
Apr 6, 2015
Merged

#744: Add 'pubsub.message.Message' class #800

tseaver merged 2 commits into from
Apr 6, 2015

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 6, 2015

Also, convert factory helper functions for topics and subscriptions into from_api_repr class methods.

@tseaver
Move api factory helpers into class methods:
1052aad 
- 'api._topic_from_resource' -> 'Topic.from_api_repr'
- 'api._subscription_from_resource' -> 'Subscription.from_api_repr'
@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Apr 6, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2015
@tseaver tseaver mentioned this pull request Apr 6, 2015
Closed
9 tasks
dhermes
dhermes reviewed Apr 6, 2015
View reviewed changes
gcloud/pubsub/message.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Apr 6, 2015

What's the necessity of a Message class? In our original document, it wasn't clear if one would ever need to exist.

@tseaver
Copy link
Contributor Author

tseaver commented Apr 6, 2015

Mostly, the message has some behavior that differs from the raw mappings: base64-decoding the payload, for one. If we need to add support for timestamping / serial handling, then it gives us a place to hang it on the subscriber side.

@dhermes
Copy link
Contributor

dhermes commented Apr 6, 2015

OK LGTM. I'm not sure I buy the savings of using None instead of {} on an object, but not worth getting hung up on.

@tseaver
Add 'pubsub.message.Message' class.
6a5f480 
Maps 'pubsub.v1beta2.PubsubMessage', handles base64-decode of payload.

Return 'Message' instances from 'Subscription.pull()'.

Update docs accordingly.
@tseaver
Copy link
Contributor Author

tseaver commented Apr 6, 2015

Squashed down to 2 commits. I will merge when Travis pulls its thumb out.

@coveralls
Copy link

coveralls commented Apr 6, 2015

Coverage Status

Changes Unknown when pulling 6a5f480 on tseaver:744-pubsub-message_class into * on GoogleCloudPlatform:master*.

tseaver added a commit that referenced this pull request Apr 6, 2015
@tseaver
Merge pull request #800 from tseaver/744-pubsub-message_class
9c7f1fd 
#744: Add 'pubsub.message.Message' class
@tseaver tseaver merged commit 9c7f1fd into googleapis:master Apr 6, 2015
@tseaver tseaver deleted the 744-pubsub-message_class branch April 6, 2015 22:19
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
parthea pushed a commit that referenced this pull request Aug 21, 2025
@gcf-owl-bot
chore(python): use python 3.10 for docs build (#800)
97b9fc8 
Source-Link: googleapis/synthtool@9ae0785
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:52210e0e0559f5ea8c52be148b33504022e1faef4e95fbe4b32d68022af2fa7e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@gcf-owl-bot @parthea
chore(python): use python 3.10 for docs build (#800)
f856f5d 
Source-Link: googleapis/synthtool@9ae0785
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:52210e0e0559f5ea8c52be148b33504022e1faef4e95fbe4b32d68022af2fa7e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
@renovate-bot
chore(deps): update dependency pytest to v8.3.2 (#800)
7b8462b
parthea pushed a commit that referenced this pull request Nov 24, 2025
@renovate-bot
chore(deps): update dependency google-api-core to v1.26.1 (#800)
a5b5e7b 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-api-core](https://togithub.com/googleapis/python-api-core) | `==1.26.0` -> `==1.26.1` | [![age](https://badges.renovateapi.com/packages/pypi/google-api-core/1.26.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-api-core/1.26.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-api-core/1.26.1/compatibility-slim/1.26.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-api-core/1.26.1/confidence-slim/1.26.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/python-api-core</summary>

### [`v1.26.1`](https://togithub.com/googleapis/python-api-core/blob/master/CHANGELOG.md#&#8203;1261-httpswwwgithubcomgoogleapispython-api-corecomparev1260v1261-2021-02-12)

[Compare Source](https://togithub.com/googleapis/python-api-core/compare/v1.26.0...v1.26.1)

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-python).
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea @gcf-owl-bot
build: use mypy<1.15.0 until #799 is fixed (#800)
8cc7ba1 
* build: use mypy<1.15.0 until #799 is fixed

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: rename rst files to avoid conflict with service names (#800)
0bf4ba5 
Source-Link: googleapis/synthtool@d52e638
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: detect samples tests in nested directories (#800)
ee386ba 
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
parthea pushed a commit that referenced this pull request Nov 25, 2025
@gcf-owl-bot
chore: rename rst files to avoid conflict with service names (#800)
e2a77c5 
Source-Link: googleapis/synthtool@d52e638
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@release-please
chore: release 1.33.0 (#800)
64efd43 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @dhermes @coveralls @googlebot