Skip to content

Storage: deprecate 'fields' arg to 'Bucket.list_blobs'.#7897

Closed
tseaver wants to merge 2 commits intogoogleapis:masterfrom
tseaver:7875-storage-deprecate-fields-arg-to-list_blobs
Closed

Storage: deprecate 'fields' arg to 'Bucket.list_blobs'.#7897
tseaver wants to merge 2 commits intogoogleapis:masterfrom
tseaver:7875-storage-deprecate-fields-arg-to-list_blobs

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented May 8, 2019

Closes #7875.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 8, 2019
@tseaver tseaver requested a review from frankyn May 8, 2019 15:56
@tseaver tseaver requested a review from crwilcox as a code owner May 8, 2019 15:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
@frankyn
Copy link
Copy Markdown
Contributor

frankyn commented May 8, 2019

Thanks for looping me in @tseaver. This field isn't deprecated and documented here instead:
https://cloud.google.com/storage/docs/json_api/v1/how-tos/performance

The field is actively used by the google-cloud-java library for Storage for metadata field selection.

I'll file a bug against cloud documentation on surfacing the field in Objects.List and other ref docs.

INTERNAL BUG: 132247394

@xmedeko
Copy link
Copy Markdown
Contributor

xmedeko commented May 8, 2019

@tseaver beside the warning, the deprecation should be in the method doc, too. (If this change is accepted.)

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 8, 2019

@frankyn OK, then do you think we need to add a method which makes fields useful, e.g. Bucket.list_blob_info? Using it at all breaks Bucket.list_blobs.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented May 17, 2019

Superseded by #8023.

@tseaver tseaver closed this May 17, 2019
@tseaver tseaver deleted the 7875-storage-deprecate-fields-arg-to-list_blobs branch May 17, 2019 20:05
tseaver added a commit that referenced this pull request May 18, 2019
parthea pushed a commit that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage: Bucket.list_blobs fields param doc

5 participants