Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 31, 2015

Fixes #738.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2015
@tseaver
Copy link
Contributor

tseaver commented Mar 31, 2015

LGTM

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 31, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ed629eb on dhermes:fix-738 into 24ba02b on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Mar 31, 2015
Renaming _patch_properties->_patch_property and accepting key, value.
@dhermes dhermes merged commit 7fa0ae2 into googleapis:master Mar 31, 2015
@dhermes dhermes deleted the fix-738 branch March 31, 2015 18:52
parthea pushed a commit that referenced this pull request Nov 22, 2025
* docs(samples): add read table snippet

* remove snippet as it already exists
parthea pushed a commit that referenced this pull request Nov 24, 2025
The motivation for this is to prevent a breaking change in a library that has already been made GA: texttospeech googleapis/python-texttospeech#99. The TTS protos have a field named [`input`](https://github.com/googleapis/googleapis/blob/eabe7c0fde64b1451df6ea171b2009238b0df07c/google/cloud/texttospeech/v1/cloud_tts.proto#L134-L143).

Dialogflow CX beta appears to also have a field named `input`, but those changes have not yet been published and it is a pre-GA API.

https://github.com/search?l=Python&p=1&q=org%3Agoogleapis+input_&type=Code
parthea pushed a commit that referenced this pull request Nov 24, 2025
…[autoapprove] (#788)

* chore(python): exclude path in renovate.json [autoapprove]

Source-Link: googleapis/synthtool@69fabae
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
* tests: pass '*session.posargs' for systests

Permits running single tests, debugging on errors, etc.

* fix: typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

STORAGE: _patch_properties is never called with more than one key in the dict

4 participants