Skip to content

Phishing Protection: Finish initial library setup.#7865

Closed
busunkim96 wants to merge 5 commits intogoogleapis:masterfrom
busunkim96:phishing-protection-fix
Closed

Phishing Protection: Finish initial library setup.#7865
busunkim96 wants to merge 5 commits intogoogleapis:masterfrom
busunkim96:phishing-protection-fix

Conversation

@busunkim96
Copy link
Copy Markdown
Contributor

The previous generation had several steps missing, and that release ended up failing. This finishes out the setup.

  • Rename of package from google-cloud-phishingprotection to google-cloud-phishing-protectionwith a replace in synth.py.
  • Complete docs setup.
  • Exclude un-executed line in types.py so unit tests do not fail.
  • Fix classifier in setup.py.

@busunkim96 busunkim96 requested a review from tseaver May 6, 2019 23:18
@busunkim96 busunkim96 requested a review from crwilcox as a code owner May 6, 2019 23:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2019
@busunkim96 busunkim96 added the api: phishingprotection Issues related to the Phishing Protection API. label May 6, 2019
@busunkim96 busunkim96 force-pushed the phishing-protection-fix branch from 418949f to 6d3ecd3 Compare May 6, 2019 23:23
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented May 7, 2019

@busunkim96 In addition to renaming the distutils project, do we want to rename the phishingprotection directory to phishing_protection?

@busunkim96 busunkim96 force-pushed the phishing-protection-fix branch from e83c78f to 9f0736e Compare May 9, 2019 22:45
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 13, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@busunkim96 busunkim96 closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: phishingprotection Issues related to the Phishing Protection API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants