Skip to content

Accomodate JSON services which do not return JSON payloads for errors.#764

Closed
tseaver wants to merge 1 commit intogoogleapis:masterfrom
tseaver:json_api-non_json_errors
Closed

Accomodate JSON services which do not return JSON payloads for errors.#764
tseaver wants to merge 1 commit intogoogleapis:masterfrom
tseaver:json_api-non_json_errors

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Mar 27, 2015

I'm lookin' at you, pubsub.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 27, 2015
@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Mar 27, 2015

WAT? @tmatsuo Can we file a formal bug about not using JSON errors from a discovery-based API?

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 27, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 25f92d2 on tseaver:json_api-non_json_errors into d34a15e on GoogleCloudPlatform:master.

This was referenced Mar 27, 2015
Merged
Merged
@tmatsuo
Copy link
Copy Markdown
Contributor

tmatsuo commented Mar 27, 2015

This is presumably because Pub/Sub is on the newer infrastructure.

I assume other APIs return JSON errors. Is that behavior defined somewhere? or are you just expecting the same behavior as other APIs?

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Mar 27, 2015

@tmatsuo storage returns JSON: https://cloud.google.com/storage/docs/json_api/v1/status-codes#errorformat

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Mar 27, 2015

@tseaver this LGTM but can you capture the raw content in an api_request and post it, just so I can see?

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Mar 27, 2015

@tmatsuo JSON half the time is crazy, no matter the infrastructure. Please send my feedback into the black hole of feedback.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Mar 27, 2015

Hmm, I was working with a bad API_BASE_URL earlier, which means the No Content was not generated by the pubsub API. It actually returns:

{
  "error": {
    "code": 404,
    "message": "Resource not found (resource=a-new-topic).",
    "status": "NOT_FOUND"
  }
}

@tseaver tseaver closed this Mar 27, 2015
@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Mar 27, 2015

Yay!

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Mar 27, 2015

@tmatsuo My feedback turns out to be irrelevant! w00t!

@tmatsuo
Copy link
Copy Markdown
Contributor

tmatsuo commented Mar 27, 2015

Good to know!

@tseaver tseaver deleted the json_api-non_json_errors branch May 1, 2015 14:21
parthea pushed a commit that referenced this pull request Aug 21, 2025
@gcf-owl-bot
chore: Update gapic-generator-python to v1.16.1 (#764)
0ca24c3 
* chore: Update gapic-generator-python to v1.16.1

PiperOrigin-RevId: 618243632

Source-Link: googleapis/googleapis@078a38b

Source-Link: googleapis/googleapis-gen@7af768c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2FmNzY4YzNmOGNlNTg5OTQ0ODIzNTBmNzQwMTE3MzMyOTk1MGEzMSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@gcf-owl-bot @parthea
chore: Update gapic-generator-python to v1.16.1 (#764)
b5000ec 
* chore: Update gapic-generator-python to v1.16.1

PiperOrigin-RevId: 618243632

Source-Link: googleapis/googleapis@078a38b

Source-Link: googleapis/googleapis-gen@7af768c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2FmNzY4YzNmOGNlNTg5OTQ0ODIzNTBmNzQwMTE3MzMyOTk1MGEzMSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
@chalmerlowe @gcf-owl-bot
test: add pip freeze to several sessions in the noxfile to aid in t…
29d164a 
…roubleshooting (#764)

* add pip freeze to various noxfile tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
@billyjacobson
docs: fix delete from column family example (#764)
6184eac 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore: release 0.40.7 (#764)
c152ce8 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore(main): release 2.24.0 (#764)
291d009 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore(python): use ubuntu 22.04 in docs image (#764)
2e27798 
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
parthea added a commit that referenced this pull request Mar 2, 2026
@gcf-owl-bot @parthea
chore: use gapic-generator-python 1.2.0 (#764)
fba3e25 
* chore: use gapic-generator-python 1.2.0

PiperOrigin-RevId: 467286830

Source-Link: googleapis/googleapis@e6e875a

Source-Link: googleapis/googleapis-gen@0295ea1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDI5NWVhMTRkOWNkNGQ0N2RkYjIzYjllYmQzOWEzMWUyMDM1ZTI4ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* remove replacements in owlbot.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
chore(deps): update dependency google-auth to v2.41.1 (#764)
bd2ae54
parthea pushed a commit that referenced this pull request Mar 9, 2026
@release-please
chore(main): release 3.16.0 (#764)
36a4731 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tseaver @dhermes @coveralls @tmatsuo @googlebot