Skip to content

Remove properties= from Blob and Bucket constructors #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 2 commits into from
Mar 28, 2015
Merged

Remove properties= from Blob and Bucket constructors #760

dhermes merged 2 commits into from
Mar 28, 2015

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 25, 2015

NOTE: Has #759 as a diffbase.

This is an implementation detail intended to make internal code have an easier time constructing entities, but never had a story for end-users.

The only real changes are effectively:

-            yield Bucket(properties=item, connection=self._ctor_connection)
+            name = item.get('name')
+            bucket = Bucket(name, connection=self._ctor_connection)
+            bucket._properties = item
+            yield bucket

For test conveniences, I've allowed _makeOne() to delegate the properties= keyword in the way it used to be used in the actual constructors.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2015
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 25, 2015
@dhermes dhermes force-pushed the remove-properties-from-constructor branch from 7ed8baa to 9cd15a6 Compare March 25, 2015 22:35
@coveralls
Copy link

coveralls commented Mar 25, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 9cd15a6 on dhermes:remove-properties-from-constructor into d34a15e on GoogleCloudPlatform:master.

@coveralls
Copy link

coveralls commented Mar 25, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 9cd15a6 on dhermes:remove-properties-from-constructor into d34a15e on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Mar 26, 2015

Changes relative to #759 LGTM.

@dhermes dhermes force-pushed the remove-properties-from-constructor branch from 9cd15a6 to 44e5b74 Compare March 28, 2015 18:01
@coveralls
Copy link

coveralls commented Mar 28, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 44e5b74 on dhermes:remove-properties-from-constructor into 3906245 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 28, 2015

@tseaver I peeled off the last two commits to separate from #759. Let me know if you're not cool with the merge.

dhermes added a commit that referenced this pull request Mar 28, 2015
@dhermes
Merge pull request #760 from dhermes/remove-properties-from-constructor
622d994 
Remove properties= from Blob and Bucket constructors
@dhermes dhermes merged commit 622d994 into googleapis:master Mar 28, 2015
@dhermes dhermes deleted the remove-properties-from-constructor branch March 28, 2015 18:04
@dhermes dhermes mentioned this pull request Mar 28, 2015
Closed
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
feat: Update Compute Engine API to revision 20221224 (#760) (#381)
03c9f20 
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Update Compute Engine API to revision 20221224 (#760)

Source-Link: googleapis/googleapis@17d5613

Source-Link: googleapis/googleapis-gen@42cd552
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDJjZDU1MmZhNWJlOTViZTVjZTUxMzZiYTkzZTgzMzg4Yjc1OTFkOCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* work around docs issue

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Aug 21, 2025
@yirutang
feat: add client side lib id with lib version (#760)
59776e2 
* .

* .

* .

* .

* .

* .
parthea pushed a commit that referenced this pull request Sep 16, 2025
@yirutang @parthea
feat: add client side lib id with lib version (#760)
4caff59 
* .

* .

* .

* .

* .

* .
parthea pushed a commit that referenced this pull request Nov 22, 2025
@shweta345
chore(samples): Fixed a typo in the readme (#760)
f1342ee
parthea pushed a commit that referenced this pull request Nov 24, 2025
@software-dov
fix: remove duplicate assignment of certain flattened, repeated fields (
dc2597f 
#760)

Fix for #756. Under certain circumstances, flattened, repeated fields
could be duplicated during request construction.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore: release 0.40.6 (#762)
4ab1632 
🤖 I have created a release \*beep\* \*boop\* 
---
### [0.40.6](https://www.github.com/googleapis/gapic-generator-python/compare/v0.40.5...v0.40.6) (2021-02-02)


### Bug Fixes

* remove duplicate assignment of certain flattened, repeated fields ([#760](https://www.github.com/googleapis/gapic-generator-python/issues/760)) ([cdbc221](https://www.github.com/googleapis/gapic-generator-python/commit/cdbc22130a176e733c529f60a6b8b1d224e82e89))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: remove pinned Sphinx version [autoapprove] (#760)
78f534c 
Source-Link: googleapis/synthtool@909573c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
@gcf-owl-bot
chore: remove pinned Sphinx version [autoapprove] (#760)
1e88f28 
Source-Link: googleapis/synthtool@909573c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@tseaver
fix: enforce constraints during unit tests (#760)
d70edbb 
Drop explicit pin / constraint on 'urllib3':  specific 'requests'
versions have very narrow pins, and ours is only likely to create
conflicts.

Bump the 'requests' lower bound to '2.20.0', the lowest version for
which our tests pass once constraints are being checked.

Closes #759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @coveralls @tseaver @googlebot